allow no line break after ( for function calls

With strict = FALSE, lines are not broken.

Author: lorenzwalthert

R/style_guides.R

@@ -95,14 +95,14 @@ tidyverse_style <- function(scope = "tokens",
         add_line_break_afer_curly_opening,
       if (strict) set_line_break_before_curly_closing else
         add_line_break_before_curly_closing,
-      partial(
+      if (strict) partial(
         set_line_break_after_opening_if_call_is_multi_line,
         except_token_after = "COMMENT",
         except_text_before = c("switch", "ifelse", "if_else")
-      ),
-      partial(
+      ) else identity,
+      if (strict) partial(
         set_line_break_before_closing_call, except_token_before = "COMMENT"
-      ),
+      ) else identity,
       remove_line_break_in_empty_fun_call,
       add_line_break_after_pipe
     )

tests/testthat/line_breaks_fun_call/token_dependent_complex_non_strict-in.R

@@ -0,0 +1,39 @@
+call(call(
+  2
+))
+
+call(call(1,
+          2))
+# multi-line: no indention based on first vall
+call(a(b(c({
+}))))
+
+call(call(
+  2 ) ,
+  5 )
+
+
+call(call(1,
+          2, c(
+            3
+          )))
+
+call(1,
+     call2(3, 4, call(3,
+                      4, call(5, 6, call(
+                        2
+                      )
+                      )
+     )
+     )
+)
+
+# comment lala
+
+call(call(
+  2
+))
+
+call(1, call(
+  23
+))

tests/testthat/line_breaks_fun_call/token_dependent_complex_non_strict-in_tree

@@ -0,0 +1,46 @@
+call(call(
+  2
+))
+
+call(call(
+  1,
+  2
+))
+# multi-line: no indention based on first vall
+call(a(b(c({
+}))))
+
+call(
+  call(
+    2
+  ),
+  5
+)
+
+
+call(call(
+  1,
+  2, c(
+    3
+  )
+))
+
+call(
+  1,
+  call2(3, 4, call(
+    3,
+    4, call(5, 6, call(
+      2
+    ))
+  ))
+)
+
+# comment lala
+
+call(call(
+  2
+))
+
+call(1, call(
+  23
+))

tests/testthat/line_breaks_fun_call/token_dependent_complex-out.R renamed to tests/testthat/line_breaks_fun_call/token_dependent_complex_non_strict-out.R

@@ -6,9 +6,14 @@ test_that("line breaks work in general", {
 
   expect_warning(test_collection("line_breaks_fun_call",
                                  "token_dependent_complex",
-                                 transformer = style_text), NA)
+                                 transformer = style_text, strict = FALSE), NA)
 })
 
+test_that("line breaks are not applied with non-strict", {
+  expect_warning(test_collection("line_breaks_fun_call",
+                                 "token_dependent_complex",
+                                 transformer = style_text), NA)
+})
 
 test_that("line breaks work with comments", {
   expect_warning(test_collection("line_breaks_fun_call",