quoted key does not mean aligned per se

lorenzwalthert · lorenzwalthert · commit 483334063a16 · 2021-12-23T12:52:43.000+01:00
diff --git a/R/detect-alignment-utils.R b/R/detect-alignment-utils.R
@@ -80,7 +80,8 @@ alignment_col1_all_named <- function(relevant_pd_by_line) {
     if (nrow(x) < 3) {
       return(FALSE)
     }
-    identical(x$token[c(1, 3)], c("SYMBOL_SUB", "expr")) &&
+    x$token[3] == "expr" &&
+      x$token[1] %in% c("SYMBOL_SUB", "STR_CONST") &&
       x$token[2] %in% c(
         "EQ_SUB", "SPECIAL-IN", "LT", "GT", "EQ", "NE"
       )
diff --git a/tests/testthat/alignment/quoted-names-in.R b/tests/testthat/alignment/quoted-names-in.R
@@ -0,0 +1,7 @@
+df <- dplyr::rename(df,
+  "xValues" =   "Time",
+  "xUnit" = "TimeUnit",
+  "yValues"   = "simulationValues",
+  "yUnit" = "unit",
+  "yDimension"  = "dimension"
+)
diff --git a/tests/testthat/alignment/quoted-names-in_tree b/tests/testthat/alignment/quoted-names-in_tree
diff --git a/tests/testthat/alignment/quoted-names-out.R b/tests/testthat/alignment/quoted-names-out.R
@@ -0,0 +1,7 @@
+df <- dplyr::rename(df,
+  "xValues" = "Time",
+  "xUnit" = "TimeUnit",
+  "yValues" = "simulationValues",
+  "yUnit" = "unit",
+  "yDimension" = "dimension"
+)

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,8 @@ alignment_col1_all_named <- function(relevant_pd_by_line) {`
`80`	`80`	`if (nrow(x) < 3) {`
`81`	`81`	`return(FALSE)`
`82`	`82`	`}`
`83`		`- identical(x$token[c(1, 3)], c("SYMBOL_SUB", "expr")) &&`
	`83`	`+ x$token[3] == "expr" &&`
	`84`	`+ x$token[1] %in% c("SYMBOL_SUB", "STR_CONST") &&`
`84`	`85`	`x$token[2] %in% c(`
`85`	`86`	`"EQ_SUB", "SPECIAL-IN", "LT", "GT", "EQ", "NE"`
`86`	`87`	`)`