Skip to content

Remove outdated col and line information #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lorenzwalthert opened this issue Aug 22, 2017 · 1 comment · Fixed by #218
Closed

Remove outdated col and line information #147

lorenzwalthert opened this issue Aug 22, 2017 · 1 comment · Fixed by #218
Assignees
@lorenzwalthert
Labels
Complexity: High Priority: Low Type: Infrastructure

Comments

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Aug 22, 2017 •
edited
Loading

Instead of leaving it outdated, remove it and add it again when recomputed as decided in #146 (comment).
@lorenzwalthert lorenzwalthert mentioned this issue Aug 22, 2017
Merged
@lorenzwalthert
Copy link
Collaborator Author

It's actually still used in some places since it serves as a key (even if the exact value is not true anymore, the ordering is (so far) always preserved in styling). So we might have to create our own key first. See #112.

@lorenzwalthert lorenzwalthert self-assigned this Sep 10, 2017
This was referenced Sep 22, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzwalthert lorenzwalthert

Labels
Complexity: High Priority: Low Type: Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated line and col information lorenzwalthert/styler
1 participant
@lorenzwalthert