Skip to content

Introduce class vertical #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lorenzwalthert opened this issue Aug 30, 2017 · 3 comments
Closed

Introduce class vertical #173

lorenzwalthert opened this issue Aug 30, 2017 · 3 comments

Comments

@lorenzwalthert
Copy link
Collaborator

To avoid

style_text(...) %>%
  cat(sep = "\n")

And simply write

style_text(...)
@lorenzwalthert
Copy link
Collaborator Author

There is one obstacle: The tests won't pass anymore since the output of style_text is not the same as the reference with regard to the attributes. However, when written to the file, the text is identical. test_collection() uses utf8::transform_lines_enc(), which test whether the input and the transformed output is identical via identical(), which seems a bit too strict for our case. It seems to me that all.equal(..., check.attributes = FALSE) would be more accurate in our situation. Should we adapt test_collection to not rely on utf8::transform_lines_enc() for the comparison?

@lorenzwalthert
Copy link
Collaborator Author

@krlmlr can you advise on that?

@krlmlr
Copy link
Member

krlmlr commented Sep 2, 2017

Can you insert an unclass() somewhere before checking equality or before calling transform_...()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants