Skip to content

No blank added at EOF when file to style already corresponds to style guide #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lorenzwalthert opened this issue Aug 16, 2019 · 0 comments · Fixed by #540
Closed

No blank added at EOF when file to style already corresponds to style guide #539

lorenzwalthert opened this issue Aug 16, 2019 · 0 comments · Fixed by #540

Comments

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Aug 16, 2019

This is because equality check if performed without taking into account if the file has a blank line at the end. The only way to figure this out is to use a lower-level implementation of xfun::read_utf8(), i.e. readLines(), catch the warning (if any) about missing blank line and propagate the information upwards in the call stack. Interacts with #320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant