removed redundant variable assignments in routes

Author: jakewmeyer

src/v2-routes/v2-capsules.js

@@ -16,10 +16,9 @@ v2.get('/', asyncHandle(async (req, res) => {
 
 // Returns specific Dragon data
 v2.get('/:capsule', asyncHandle(async (req, res) => {
-  const cap = req.params.capsule;
   const data = await global.db
     .collection('dragon')
-    .find({ id: cap }, { _id: 0 })
+    .find({ id: req.params.capsule }, { _id: 0 })
     .toArray();
   res.json(data[0]);
 }));

src/v2-routes/v2-launches.js

@@ -3,7 +3,7 @@
 const express = require('express');
 const asyncHandle = require('express-async-handler');
 const launch = require('../builders/launch-query');
-const querySort = require('../builders/launch-sort');
+const sort = require('../builders/launch-sort');
 
 const v2 = express.Router();
 
@@ -20,12 +20,10 @@ v2.get('/latest', asyncHandle(async (req, res) => {
 
 // Return all past launches filtered by any querystring
 v2.get('/', asyncHandle(async (req, res) => {
-  const query = launch.launchQuery(req);
-  const sort = querySort.launchSort(req);
   const data = await global.db
     .collection('launch_v2')
-    .find(query, { _id: 0 })
-    .sort(sort)
+    .find(launch.launchQuery(req), { _id: 0 })
+    .sort(sort.launchSort(req))
     .toArray();
   res.json(data);
 }));

src/v2-routes/v2-launchpad.js

@@ -16,10 +16,9 @@ v2.get('/', asyncHandle(async (req, res) => {
 
 // Return specific launchpad
 v2.get('/:pad', asyncHandle(async (req, res) => {
-  const id = req.params.pad;
   const data = await global.db
     .collection('launchpad')
-    .find({ id: `${id}` }, { _id: 0 })
+    .find({ id: req.params.pad }, { _id: 0 })
     .toArray();
   res.json(data);
 }));

src/v2-routes/v2-parts.js

@@ -9,21 +9,19 @@ const v2 = express.Router();
 
 // Returns all capsule information
 v2.get('/caps', asyncHandle(async (req, res) => {
-  const query = caps.capsuleQuery(req);
   const data = await global.db
     .collection('capsule')
-    .find(query, { _id: 0 })
+    .find(caps.capsuleQuery(req), { _id: 0 })
     .sort({ capsule_serial: 1 })
     .toArray();
   res.json(data);
 }));
 
 // Returns all core information
 v2.get('/cores', asyncHandle(async (req, res) => {
-  const query = cores.coreQuery(req);
   const data = await global.db
     .collection('core')
-    .find(query, { _id: 0 })
+    .find(cores.coreQuery(req), { _id: 0 })
     .sort({ core_serial: 1 })
     .toArray();
   res.json(data);

src/v2-routes/v2-rockets.js

@@ -16,10 +16,9 @@ v2.get('/', asyncHandle(async (req, res) => {
 
 // Returns specific rocket info
 v2.get('/:rocket', asyncHandle(async (req, res) => {
-  const param = req.params.rocket;
   const data = await global.db
     .collection('rocket')
-    .find({ id: `${param}` }, { _id: 0 })
+    .find({ id: req.params.rocket }, { _id: 0 })
     .toArray();
   res.json(data[0]);
 }));

src/v2-routes/v2-upcoming.js

@@ -3,18 +3,16 @@
 const express = require('express');
 const asyncHandle = require('express-async-handler');
 const launch = require('../builders/launch-query');
-const querySort = require('../builders/launch-sort');
+const sort = require('../builders/launch-sort');
 
 const v2 = express.Router();
 
 // Upcoming launches by date, year, or all
 v2.get('/', asyncHandle(async (req, res) => {
-  const query = launch.launchQuery(req);
-  const sort = querySort.launchSort(req);
   const data = await global.db
     .collection('upcoming_v2')
-    .find(query, { _id: 0 })
-    .sort(sort)
+    .find(launch.launchQuery(req), { _id: 0 })
+    .sort(sort.launchSort(req))
     .toArray();
   res.json(data);
 }));