Skip to content

Commit 426fd01

Browse files
committed
Make rabbit_fifo_dlx_sup more resilient
Previously, it used the default intensity: "intensity defaults to 1 and period defaults to 5." However, it's a bit low given there can be dozens or hundreds of DLX workers: If only 2 fail within 5 seconds, the whole supervisor terminates. Therefore, this commit bumps this value from 1 to 10. Even with a value of 10, there shouldn't be any infnite loop of the supervisor terminating and restarting childs because the rabbit_fifo_dlx_worker is terminated and started very quickly given that the (the slow) consumer registration happens in rabbit_fifo_dlx_worker:handle_continue/2.
1 parent c23fba0 commit 426fd01

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

deps/rabbit/src/rabbit_fifo_dlx_sup.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ start_link() ->
2424

2525
init([]) ->
2626
SupFlags = #{strategy => simple_one_for_one,
27-
intensity => 1,
27+
intensity => 10,
2828
period => 5},
2929
Worker = rabbit_fifo_dlx_worker,
3030
ChildSpec = #{id => Worker,

0 commit comments

Comments
 (0)