Better Selenium suite coverage for #16916

(cherry picked from commit 00b9e87)

Author: michaelklishin

selenium/bin/components/rabbitmq

@@ -111,7 +111,7 @@ start_docker_cluster_rabbitmq() {
     ${BIN_DIR}/gen-advanced-config "${PROFILES}" ${RABBITMQ_CONFIG_DIR} $ENV_FILE $CONF_DIR/rabbitmq/advanced.config
     RESULT=$?
     if [ $RESULT -eq 0 ]; then
-        if [ -s $RESULT ]; then
+        if [ -s $CONF_DIR/rabbitmq/advanced.config ]; then
             print "> EFFECTIVE ADVANCED_CONFIG_FILE: $CONF_DIR/rabbitmq/advanced.config"
         else
             rm $CONF_DIR/rabbitmq/advanced.config
@@ -163,7 +163,7 @@ start_docker_rabbitmq() {
   ${BIN_DIR}/gen-advanced-config "${PROFILES}" ${RABBITMQ_CONFIG_DIR} $ENV_FILE $CONF_DIR/rabbitmq/advanced.config
   RESULT=$?
   if [ $RESULT -eq 0 ]; then
-      if [ -s $RESULT ]; then
+      if [ -s $CONF_DIR/rabbitmq/advanced.config ]; then
           print "> EFFECTIVE ADVANCED_CONFIG_FILE: $CONF_DIR/rabbitmq/advanced.config"
       else
           rm $CONF_DIR/rabbitmq/advanced.config

selenium/suites/mgt/feature-flags.sh

@@ -4,6 +4,7 @@ SCRIPT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 TEST_CASES_PATH=/feature-flags
 TEST_CONFIG_PATH=/basic-auth
+PROFILES="ff-disabled"
 
 source $SCRIPT/../../bin/suite_template $@
 run

selenium/test/basic-auth/advanced.ff-disabled.config

@@ -0,0 +1,8 @@
+[
+  {rabbit, [
+    %% Enable every feature flag on boot except these two stable ones, so that
+    %% the feature flags page renders its "enable" affordances.
+    {forced_feature_flags_on_init,
+     {rel, [], [track_qq_members_uids, tie_binding_to_dest_with_keep_while_cond]}}
+  ]}
+].

selenium/test/feature-flags/feature-flags.js

@@ -8,6 +8,11 @@ const OverviewPage = require('../pageobjects/OverviewPage')
 const AdminTab = require('../pageobjects/AdminTab')
 const FeatureFlagsAdminTab = require('../pageobjects/FeatureFlagsAdminTab')
 
+// Both flags are stable and left disabled on boot by the suite's advanced.config.
+// Enabling a feature flag cannot be undone, so each test case needs its own.
+const TOGGLED_FEATURE_FLAG = 'track_qq_members_uids'
+const ENABLED_VIA_BUTTON_FEATURE_FLAG = 'tie_binding_to_dest_with_keep_while_cond'
+
 describe('Feature flags in Admin tab', function () {
   let driver
   let login
@@ -29,15 +34,33 @@ describe('Feature flags in Admin tab', function () {
       throw new Error('Failed to login')
     }
     await overview.selectRefreshOption("Do not refresh")
+    await overview.clickOnAdminTab()
+    await adminTab.clickOnFeatureFlags()
   })
 
   it('it has at least one feature flag', async function () {
-    await overview.clickOnAdminTab()
-    await adminTab.clickOnFeatureFlags()
     let ffTable = await ffTab.getAll()
     assert(ffTable.length > 0)
   })
 
+  it('it warns about disabled stable feature flags', async function () {
+    assert(await ffTab.isDisabledStableWarningDisplayed())
+    assert(await ffTab.isEnableAllStableFeatureFlagsEnabled())
+  })
+
+  it('it enables a stable feature flag from its toggle', async function () {
+    assert(!await (await ffTab.getState(TOGGLED_FEATURE_FLAG)).isSelected())
+    await ffTab.enable(TOGGLED_FEATURE_FLAG)
+    await ffTab.waitUntilEnabled(TOGGLED_FEATURE_FLAG)
+  })
+
+  it('it enables the remaining stable feature flags from the warning button', async function () {
+    assert(!await (await ffTab.getState(ENABLED_VIA_BUTTON_FEATURE_FLAG)).isSelected())
+    await ffTab.clickOnEnableAllStableFeatureFlags()
+    await ffTab.waitUntilEnabled(ENABLED_VIA_BUTTON_FEATURE_FLAG)
+    assert(await ffTab.isDisabledStableWarningNotDisplayed())
+  })
+
   after(async function () {
     await teardown(driver, this, captureScreen)
   })

selenium/test/pageobjects/FeatureFlagsAdminTab.js

@@ -7,7 +7,10 @@ const AdminTab = require('./AdminTab')
 const FEATURE_FLAGS_SECTION = By.css('div#main div#feature-flags')
 const FEATURE_FLAGS_TABLE = By.css('div#main div#feature-flags div#ff-table-section table')
 
-const ACCEPT_ENABLE_EXPERIMENTAL_FEATURE_FLAG = By.css('p#ff-exp-ack-supported')
+const DISABLED_STABLE_WARNING = By.css('div#ff-disabled-stable-warning')
+const ENABLE_ALL_STABLE_BUTTON = By.css('button#ff-enable-all-button')
+
+const ACCEPT_ENABLE_EXPERIMENTAL_FEATURE_FLAG = By.css('input#ff-exp-ack-supported-checkbox')
 const CONFIRM_ENABLE_EXPERIMENTAL_FEATURE_FLAG = By.css('button#ff-exp-confirm')
 
 
@@ -26,32 +29,53 @@ module.exports = class FeatureFlagsAdminTab extends AdminTab {
     }
   }
 
-  async enable(name, isExperimental = false) {        
+  async enable(name, isExperimental = false) {
     let state = await this.getState(name)
     if (!await state.isSelected()) {
-      await this.driver.findElement(this.getParentCheckboxLocator(name)).click()
+      await this.click(this.getToggleLocator(name))
       if (isExperimental) {
-        await delay(1000)
         const dialog = await this.driver.wait(
-          until.elementLocated(By.css('dialog#ff-exp-dialog[open]')),
-          10000 // 10 seconds timeout
-        )
+          until.elementLocated(By.css('dialog#ff-exp-dialog[open]')), this.timeout)
         await dialog.findElement(ACCEPT_ENABLE_EXPERIMENTAL_FEATURE_FLAG).click()
-        await dialog.findElement(CONFIRM_ENABLE_EXPERIMENTAL_FEATURE_FLAG).click()      
-        return delay(1000)
-      }else {
-        return Promise.resolve()  
+        await dialog.findElement(CONFIRM_ENABLE_EXPERIMENTAL_FEATURE_FLAG).click()
       }
-    }else {
-      return Promise.resolve()
     }
   }
+
+  async clickOnEnableAllStableFeatureFlags() {
+    return this.click(ENABLE_ALL_STABLE_BUTTON)
+  }
+
+  async isDisabledStableWarningDisplayed() {
+    return this.isDisplayed(DISABLED_STABLE_WARNING)
+  }
+
+  async isDisabledStableWarningNotDisplayed() {
+    return this.isElementNotVisible(DISABLED_STABLE_WARNING)
+  }
+
+  async isEnableAllStableFeatureFlagsEnabled() {
+    const button = await this.waitForDisplayed(ENABLE_ALL_STABLE_BUTTON)
+    return button.isEnabled()
+  }
+
+  async waitUntilEnabled(name) {
+    const checkbox = await this.driver.findElement(this.getCheckboxLocator(name))
+    return this.driver.wait(until.elementIsSelected(checkbox), this.timeout,
+      'Timed out waiting for feature flag ' + name + ' to become enabled', this.polling)
+  }
+
+  // Feature flag names may contain dots, e.g. rabbitmq_4.3.0, which a CSS id
+  // selector would read as a class. Hence the attribute selectors below.
   getCheckboxLocator(name) {
-    return By.css('div#ff-table-section table input#ff-checkbox-' + name)
+    return By.css('div#ff-table-section table input[id="ff-checkbox-' + name + '"]')
   }
-  getParentCheckboxLocator(name) {
-    return By.css('div#ff-table-section table td#ff-td-' + name)
+
+  // The checkbox itself is display:none, so the toggle label is what a user clicks.
+  getToggleLocator(name) {
+    return By.css('div#ff-table-section table label[for="ff-checkbox-' + name + '"]')
   }
+
   async getState(name) {
     return this.driver.findElement(this.getCheckboxLocator(name))
   }