dialyzer fixes

Author: kjnilsson

src/osiris.erl

@@ -52,6 +52,8 @@
                           {max_age, milliseconds()}.
 
 -type writer_id() :: binary().
+-type data() :: iodata() |
+                {batch, non_neg_integer(), 0, iodata()}.
 
 -export_type([
               state/0,
@@ -62,7 +64,8 @@
               offset_spec/0,
               retention_spec/0,
               milliseconds/0,
-              writer_id/0
+              writer_id/0,
+              data/0
               ]).
 
 -spec start_cluster(config()) ->
@@ -105,7 +108,7 @@ start_replica(Replica, Config) ->
 -spec write(Pid :: pid(),
             WriterId :: binary() | undefined,
             CorrOrSeq :: non_neg_integer() | term(),
-            Data :: iodata()) -> ok.
+            Data :: data()) -> ok.
 write(Pid, WriterId, Corr, Data) ->
     osiris_writer:write(Pid, self(), WriterId, Corr, Data).
 

src/osiris_bench.erl

@@ -83,7 +83,7 @@ do_publish0(Conf, 0) ->
     end;
 do_publish0(#{leader := Leader} = Conf, InFlight) ->
     Ref = make_ref(),
-    ok = osiris:write(Leader, Ref, <<"datadata">>),
+    ok = osiris:write(Leader, undefined, Ref, <<"datadata">>),
     do_publish0(Conf, InFlight - 1).
 
 start_metrics_gatherer(Node) ->

src/osiris_log.erl

@@ -284,19 +284,18 @@ init(#{dir := Dir,
                      index_fd = IdxFd}
     end.
 
--spec write([iodata() | {batch, non_neg_integer(), 0, iodata()}], state()) ->
+-spec write([osiris:data()], state()) ->
     state().
 write(Entries, State) when is_list(Entries) ->
     Timestamp = erlang:system_time(millisecond),
     write(Entries, ?CHNK_USER, Timestamp, #{}, State).
 
--spec write([iodata() | {batch, non_neg_integer(), 0, iodata()}],
-            integer(), state()) -> state().
+-spec write([osiris:data()], integer(), state()) -> state().
 write(Entries, Now, #?MODULE{mode = #write{}} = State)
   when is_integer(Now) ->
     write(Entries, ?CHNK_USER, Now, #{}, State).
 
--spec write([iodata() | {batch, non_neg_integer(), 0, iodata()}],
+-spec write([osiris:data()],
             chunk_type(), osiris:milliseconds(),
             #{osiris:writer_id() := non_neg_integer()},
             state()) -> state().

src/osiris_writer.erl

@@ -128,7 +128,7 @@ ack(LeaderPid, Offset) when is_integer(Offset) andalso Offset >= 0 ->
             Sender :: pid(),
             WriterId :: binary() | undefined,
             CorrOrSeq :: non_neg_integer() | term(),
-            Data :: iodata()) -> ok.
+            Data :: osiris:data()) -> ok.
 write(Pid, Sender, WriterId, Corr, Data)
   when is_pid(Pid) andalso
        is_pid(Sender) ->