Skip to content

Commit f014a76

Browse files
committed
Revert "Disable tests-with-broker and standalone-tests if there is nothing to do"
This breaks some testsuites because the WITH_* variables are defined after rabbitmq-test.mk is loaded, so the ifneq() test always fails. We need another solution. This reverts commit 8fd4dea.
1 parent c606817 commit f014a76

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

mk/rabbitmq-tests.mk

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ TEST_BEAM_DIRS = $(CURDIR)/test \
1313

1414
pre-standalone-tests:: virgin-test-tmpdir
1515

16-
ifneq ($(WITH_BROKER_SETUP_SCRIPTS)$(WITH_BROKER_TEST_COMMANDS)$(WITH_BROKER_TEST_SCRIPTS),)
17-
tests:: tests-with-broker
16+
tests:: tests-with-broker standalone-tests
1817

1918
tests-with-broker: pre-standalone-tests test-dist
2019
$(verbose) rm -f $(TEST_TMPDIR)/.passed
@@ -60,10 +59,6 @@ tests-with-broker: pre-standalone-tests test-dist
6059
$(verbose) echo 'rabbit_misc:report_cover(), init:stop().' | $(ERL_CALL) $(ERL_CALL_OPTS) >/dev/null
6160
$(verbose) sleep 1
6261
$(verbose) test -f $(TEST_TMPDIR)/.passed
63-
endif
64-
65-
ifneq ($(STANDALONE_TEST_COMMANDS)$(STANDALONE_TEST_SCRIPTS),)
66-
tests:: standalone-tests
6762

6863
standalone-tests: pre-standalone-tests test-dist
6964
$(exec_verbose) $(if $(STANDALONE_TEST_COMMANDS), \
@@ -85,7 +80,6 @@ standalone-tests: pre-standalone-tests test-dist
8580
TEST_TMPDIR='$(TEST_TMPDIR)' \
8681
RABBITMQCTL='$(RABBITMQCTL)' \
8782
$(SCRIPT) &&) :)
88-
endif
8983

9084
# Add an alias for the old `make test` target.
9185
.PHONY: test

0 commit comments

Comments
 (0)