Skip to content

Import (some?) definitions after enabling plugins #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelklishin opened this issue Nov 30, 2019 · 6 comments
Closed

Import (some?) definitions after enabling plugins #2177

michaelklishin opened this issue Nov 30, 2019 · 6 comments
Milestone

Comments

@michaelklishin
Copy link
Collaborator

See rabbitmq/rabbitmq-shovel#13 for background.

Definition import was moved into the core but we still perform it before enabling plugins. I wonder if this should be the other way around. Admittedly there's a chicken-and-egg problem here either way: plugins can potentially depend on definitions (e.g. policies and parameters) and definitions can depend on plugins.

We can introduce a separate "delayed import" setting for definitions that depend on plugins being enabled.

@lukebakken
Copy link
Collaborator

@michaelklishin it seems that this issue is related - rabbitmq/rabbitmq-sharding#39

@michaelklishin
Copy link
Collaborator Author

Addressed in #2384.

@michaelklishin michaelklishin added this to the 3.8.6 milestone Jul 1, 2020
@michaelklishin
Copy link
Collaborator Author

Addressed in #2384 which will ship in 3.8.6. Those on earlier versions can always import definitions after node startup.

@ebuildy
Copy link

ebuildy commented Jul 1, 2020

Do you know when the bug appears? its working fine with 3.7.8

@lukebakken
Copy link
Collaborator

RabbitMQ version 3.8.4.

@michaelklishin
Copy link
Collaborator Author

It's not new in 3.8.4 but it affects more plugin types as of 3.8.4 because boot code paths have been substantially refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants