Skip to content

Backport "Make RabbitMQ a regular Erlang/OTP application" to RabbitMQ 3.8.x #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dumbbell opened this issue Mar 19, 2020 · 8 comments
Closed
Assignees
Milestone

Comments

@dumbbell
Copy link
Collaborator

This issue allows us to track the progress of the backport of #2180 to RabbitMQ 3.8.x.

@gerhard
Copy link
Contributor

gerhard commented Mar 19, 2020

Looking forward to this getting into 3.8 🎉

@dumbbell
Copy link
Collaborator Author

The backport is done and tested successfully locally. I verified the diff between those backport branches and master branches to make sure I didn't forget a commit.

The only difference around those changes is related to the product info. Some commits were already backported to v3.8.x, but not everything. I'm not adding the missing bits now because it is out-of-scope.

I just fixed the pull request to the broker (#2282): it was based on master, not v3.8.x. The patch doesn change and I restarted the test on Travis.

@lukebakken
Copy link
Collaborator

Some commits were already backported to v3.8.x, but not everything. I'm not adding the missing bits now because it is out-of-scope.

How can we keep track of what is missing?

@dumbbell
Copy link
Collaborator Author

dumbbell commented Mar 24, 2020

How can we keep track of what is missing?

They are still to be QA'd in master and were backported prematurely. So once everything is finished in master, I will take care of backporting everything at once.

@lukebakken
Copy link
Collaborator

Thanks @dumbbell !

@michaelklishin
Copy link
Collaborator

Are there more backports pending?

@dumbbell
Copy link
Collaborator Author

Yes, at least #2277 which is not ready yet.

@dumbbell
Copy link
Collaborator Author

dumbbell commented May 4, 2020

#2277 was merged to master and backported to 3.8.x.

@dumbbell dumbbell closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants