Merge pull request #97 from shamne/has_many

Avoid unnecessary external find to has_many association

Author: guilleiguaran

lib/active_resource/associations.rb

@@ -144,8 +144,10 @@ def defines_has_many_finder_method(method_name, association_model)
         instance_variable_get(ivar_name)
       elsif attributes.include?(method_name)
         attributes[method_name]
-      else
+      elsif !new_record?
         instance_variable_set(ivar_name, association_model.find(:all, :params => {:"#{self.class.element_name}_id" => self.id}))
+      else
+        instance_variable_set(ivar_name, self.class.collection_parser.new)
       end
     end
   end

test/cases/association_test.rb

@@ -38,6 +38,12 @@ def test_has_many
     assert_equal 1, External::Person.reflections.select{|name, reflection| reflection.macro.eql?(:has_many)}.count
   end
 
+  def test_has_many_on_new_record
+    Post.send(:has_many, :topics)
+    Topic.stubs(:find).returns([:unexpected_response])
+    assert_equal [], Post.new.topics.to_a
+  end
+
   def test_has_one
     External::Person.send(:has_one, :customer)
     assert_equal 1, External::Person.reflections.select{|name, reflection| reflection.macro.eql?(:has_one)}.count