Merge pull request #744 from rails/pc-signal-exit-code

Pass signaled exit code properly to the client

Author: rafaelfranca

lib/spring/application.rb

@@ -378,10 +378,10 @@ def wait(pid, streams, client)
       Spring.failsafe_thread {
         begin
           _, status = Process.wait2 pid
-          log "#{pid} exited with #{status.exitstatus}"
+          log "#{pid} exited with #{status.exitstatus || status.inspect}"
 
           streams.each(&:close)
-          client.puts(status.exitstatus)
+          client.puts(status.exitstatus || status.to_i)
           client.close
         ensure
           @mutex.synchronize { @waiting.delete pid }

lib/spring/client/run.rb

@@ -184,11 +184,16 @@ def run_command(client, application)
           suspend_resume_on_tstp_cont(pid)
 
           forward_signals(application)
-          status = application.read.to_i
+          status = application.read
+          log "got exit status #{status.inspect}"
 
-          log "got exit status #{status}"
+          # Status should always be an integer. If it is empty, something unexpected must have happened to the server.
+          if status.to_s.strip.empty?
+            log "unexpected empty exit status, app crashed?"
+            exit 1
+          end
 
-          exit status
+          exit status.to_i
         else
           log "got no pid"
           exit 1

test/support/acceptance_test.rb

@@ -747,6 +747,12 @@ class MyEngine < Rails::Engine
 
         assert_failure app.spring_test_command, stderr: "omg (RuntimeError)"
       end
+
+      test "passes exit code from exit and signal" do
+        artifacts = app.run("bin/rails runner 'Process.exit(7)'")
+        code = artifacts[:status].exitstatus || artifacts[:status].termsig
+        assert_equal 7, code, "Expected exit status to be 7, but was #{code}"
+      end
     end
   end
 end