-
Notifications
You must be signed in to change notification settings - Fork 961
Update String Transform Examples #19407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.08
Are you sure you want to change the base?
Conversation
Co-authored-by: Bradley Dice <[email protected]>
@@ -411,6 +412,8 @@ void write_csv(data_sink* out_sink, | |||
// write header: column names separated by delimiter: | |||
// (even for tables with no rows) | |||
// | |||
cudf::scoped_range range("io::csv::write_csv"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhaseeb123 Is this where you would put the scoped range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me as this is the main CSV write function that gets called from cudf::io::write_csv
and I don't see any CUDF_FUNC_RANGE()
in any of the functions called from in here so this one should capture the complete write_csv time. In future, we might want to put scoped ranges in maybe (write_chunked_begin
and write_chunked
for better granularity). Wdyt @vuule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, scoped range is used to make a range within a code block. That means, we can have multiple scoped ranges in a single function. On the other hand, CUDF_FUNC_RANGE
is used to generate a (scoped)range for the entire function, at the top function level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this scoped range is at the top function level so it should be equivalent to CUDF_FUNC_RANGE
.
Co-authored-by: Nghia Truong <[email protected]>
Co-authored-by: Nghia Truong <[email protected]>
Description
This pull request makes changes needed for the string transforms examples. It:
cudf::io::write_csv
Closes #19041
Checklist