Fix _aggregate_metrics_timeseries_dicts_by_key naming

Signed-off-by: Arthur Leung <arcyleung@gmail.com>

Author: Arthur Leung

python/ray/serve/_private/autoscaling_state.py

@@ -306,11 +306,11 @@ def _collect_handle_running_requests_by_replica(
             for replica_id, timeseries in handle_running.items():
                 # Only include replicas that are currently running for this deployment
                 if replica_id in self._running_replicas:
-                    timeseries_by_replica[replica_id].append(timeseries)
+                    timeseries_by_replica[replica_id].extend(timeseries)
 
-        return dict(timeseries_by_replica)
+        return timeseries_by_replica
 
-    def _aggregate_metric(
+    def _aggregate_metrics_timeseries_dicts_by_key(
         self,
         metrics_timeseries_dicts: List[Dict[str, List[TimeStampedValue]]],
         metric_key: str = ONGOING_REQUESTS_KEY,
@@ -400,7 +400,7 @@ def _aggregate_running_requests(
         Returns:
             The time-weighted average of the running requests
         """
-        return self._aggregate_metric_timeseries(
+        return self._aggregate_metrics_timeseries_dicts_by_key(
             metrics_timeseries_dicts, RUNNING_REQUESTS_KEY
         )
 
@@ -445,7 +445,7 @@ def _aggregate_controller_metrics(self) -> dict[str, float]:
 
             # Aggregate the timeseries data for this metric
             if metrics_timeseries_dicts:
-                aggregated_value = self._aggregate_metric_timeseries(
+                aggregated_value = self._aggregate_metrics_timeseries_dicts_by_key(
                     metrics_timeseries_dicts, metric_key
                 )
                 aggregated_metrics[metric_key] = aggregated_value
@@ -588,7 +588,7 @@ def _calculate_total_requests_aggregate_mode(
         for timeseries in queued_timeseries:
             ongoing_requests_metrics.append({ONGOING_REQUESTS_KEY: timeseries})
         # Aggregate and add running requests to total
-        ongoing_requests_avg = self._aggregate_metric(
+        ongoing_requests_avg = self._aggregate_metrics_timeseries_dicts_by_key(
             ongoing_requests_metrics, ONGOING_REQUESTS_KEY
         )
 
@@ -679,9 +679,9 @@ def get_total_num_requests_and_aggregate_metrics(
         self,
     ) -> tuple[
         float,
-        dict[ReplicaID, float],
-        dict[str, Dict[ReplicaID, List[Any]]],
-        dict[str, float],
+        Dict[ReplicaID, float],
+        Dict[ReplicaID, List[Any]],
+        Dict[str, float],
     ]:
         """Get average total number of requests aggregated over the past
         `look_back_period_s` number of seconds.