refactor: rename platform to platformConfig

Author: okwasniewski

packages/cli-platform-apple/src/commands/buildCommand/createBuild.ts

@@ -12,18 +12,18 @@ import {supportedPlatforms} from '../../config/supportedPlatforms';
 const createBuild =
   ({platformName}: BuilderCommand) =>
   async (_: Array<string>, ctx: Config, args: BuildFlags) => {
-    const platform = ctx.project[platformName] as IOSProjectConfig;
+    const platformConfig = ctx.project[platformName] as IOSProjectConfig;
     if (
-      platform === undefined ||
+      platformConfig === undefined ||
       supportedPlatforms[platformName] === undefined
     ) {
-      throw new CLIError(`Unable to find ${platform} platform config`);
+      throw new CLIError(`Unable to find ${platformConfig} platform config`);
     }
 
     let installedPods = false;
-    if (platform?.automaticPodsInstallation || args.forcePods) {
-      const isAppRunningNewArchitecture = platform?.sourceDir
-        ? await getArchitecture(platform?.sourceDir)
+    if (platformConfig?.automaticPodsInstallation || args.forcePods) {
+      const isAppRunningNewArchitecture = platformConfig?.sourceDir
+        ? await getArchitecture(platformConfig?.sourceDir)
         : undefined;
 
       await resolvePods(ctx.root, ctx.dependencies, platformName, {
@@ -35,7 +35,7 @@ const createBuild =
     }
 
     let {xcodeProject, sourceDir} = getXcodeProjectAndDir(
-      platform,
+      platformConfig,
       platformName,
       installedPods,
     );

packages/cli-platform-apple/src/commands/logCommand/createLog.ts

@@ -20,14 +20,14 @@ type Args = {
 const createLog =
   ({platformName}: BuilderCommand) =>
   async (_: Array<string>, ctx: Config, args: Args) => {
-    const platform = ctx.project[platformName] as IOSProjectConfig;
+    const platformConfig = ctx.project[platformName] as IOSProjectConfig;
     const {readableName: platformReadableName} = getPlatformInfo(platformName);
 
     if (
-      platform === undefined ||
+      platformConfig === undefined ||
       supportedPlatforms[platformName] === undefined
     ) {
-      throw new CLIError(`Unable to find ${platform} platform config`);
+      throw new CLIError(`Unable to find ${platformConfig} platform config`);
     }
 
     // Here we're using two command because first command `xcrun simctl list --json devices` outputs `state` but doesn't return `available`. But second command `xcrun xcdevice list` outputs `available` but doesn't output `state`. So we need to connect outputs of both commands.

packages/cli-platform-apple/src/commands/runCommand/createRun.ts

@@ -51,12 +51,12 @@ const createRun =
   async (_: Array<string>, ctx: Config, args: FlagsT) => {
     // React Native docs assume platform is always ios/android
     link.setPlatform('ios');
-    const platform = ctx.project[platformName] as IOSProjectConfig;
+    const platformConfig = ctx.project[platformName] as IOSProjectConfig;
     const {sdkNames, readableName: platformReadableName} =
       getPlatformInfo(platformName);
 
     if (
-      platform === undefined ||
+      platformConfig === undefined ||
       supportedPlatforms[platformName] === undefined
     ) {
       throw new CLIError(
@@ -67,9 +67,9 @@ const createRun =
     let {packager, port} = args;
     let installedPods = false;
     // check if pods need to be installed
-    if (platform?.automaticPodsInstallation || args.forcePods) {
-      const isAppRunningNewArchitecture = platform?.sourceDir
-        ? await getArchitecture(platform?.sourceDir)
+    if (platformConfig?.automaticPodsInstallation || args.forcePods) {
+      const isAppRunningNewArchitecture = platformConfig?.sourceDir
+        ? await getArchitecture(platformConfig?.sourceDir)
         : undefined;
 
       await resolvePods(ctx.root, ctx.dependencies, platformName, {
@@ -101,7 +101,7 @@ const createRun =
     }
 
     let {xcodeProject, sourceDir} = getXcodeProjectAndDir(
-      platform,
+      platformConfig,
       platformName,
       installedPods,
     );