Skip to content

Commit a00a896

Browse files
blakefthymikee
authored andcommitted
feat: only show --verbose flag if there are hidden logs (#1925)
We currently always show details about this flag. The change will only log this message if there are debug log messages an the user is not in --verbose mode.
1 parent 58cc6fb commit a00a896

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/cli-tools/src/logger.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const SEPARATOR = ', ';
44

55
let verbose = false;
66
let disabled = false;
7+
let hidden = false;
78

89
const formatMessages = (messages: Array<string>) =>
910
chalk.reset(messages.join(SEPARATOR));
@@ -35,6 +36,8 @@ const error = (...messages: Array<string>) => {
3536
const debug = (...messages: Array<string>) => {
3637
if (verbose && !disabled) {
3738
console.log(`${chalk.gray.bold('debug')} ${formatMessages(messages)}`);
39+
} else {
40+
hidden = true;
3841
}
3942
};
4043

@@ -58,6 +61,8 @@ const enable = () => {
5861
disabled = false;
5962
};
6063

64+
const hasDebugMessages = () => hidden;
65+
6166
export default {
6267
success,
6368
info,
@@ -67,6 +72,7 @@ export default {
6772
log,
6873
setVerbose,
6974
isVerbose,
75+
hasDebugMessages,
7076
disable,
7177
enable,
7278
};

packages/cli/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const handleError = (err: Error) => {
3030
if (err.stack) {
3131
logger.log(err.stack);
3232
}
33-
if (!program.opts().verbose) {
33+
if (!program.opts().verbose && logger.hasDebugMessages()) {
3434
logger.info(
3535
chalk.dim(
3636
`Run CLI with ${chalk.reset('--verbose')} ${chalk.dim(

0 commit comments

Comments
 (0)