[PATCH] Applying updates as discussed in re-review (- WIP #184 -)

### ChangeLog:

Changes in file .github/tool_checkmake.sh:
 export -f check_command
 readonly EMSG="Checkmake linter complained."

Changes in file .github/workflows/bandit.yml:
 jobs:

Changes in file .github/workflows/makefile-lint.yml:
 jobs:

Changes in file .github/workflows/markdown-lint.yml:
 jobs:

Changes in file .github/workflows/yaml-lint.yml:
 jobs:

Changes in file tests/check_pip:
 check_command git ;

Author: reactive-firewall

.github/tool_checkmake.sh

@@ -85,6 +85,12 @@ check_command grep ;
 check_command cut ;
 check_command checkmake ;
 
+# USAGE:
+#   ~$ usage
+# Arguments:
+#   None
+# Results:
+#   Prints usage information and exits with status code 2.
 function usage() {
 	printf "Usage: %s <makefile_path>\n" "${SCRIPT_NAME}" >&2
 	exit 2
@@ -104,8 +110,24 @@ if [[ ! ( -f "${FILE}" ) ]]; then
 fi
 
 # Main functionality
-{ { checkmake "${FILE}" | sed -e 's/   /:/g' | tr -s ':' |\
-cut -d: -f 3-5 ;} 2>/dev/null |\
-grep -F "${FILE}" | sed -E -e 's/^[[:space:]]+//g' |\
-xargs -I{} printf "::warning file=${FILE},title=LINT::%s ${EMSG}\n" {} >&2 ;}
-wait ;
+process_checkmake_output() {
+	local file="$1"
+	local emsg="$2"
+
+	if ! output=$(checkmake "${file}" 2>&1); then
+		printf "%s\n" "::error::checkmake failed: ${output}" >&2
+		return 1
+	fi
+
+	printf "%s\n" "${output}" | \
+		sed -e 's/   /:/g' | \
+		tr -s ':' | \
+		cut -d: -f 3-5 | \
+		grep -F "${file}" | \
+		sed -E -e 's/^[[:space:]]+//g' | \
+		while IFS= read -r line; do
+			printf "%s\n" "::warning file=${file},title=LINT::${line} ${emsg}" >&2
+		done
+}
+
+process_checkmake_output "${FILE}" "${EMSG}"

.github/workflows/bandit.yml

@@ -29,7 +29,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@4
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
       - name: Bandit Scan

.github/workflows/makefile-lint.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@4
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
       - name: Install Apt-Get Dependencies

.github/workflows/markdown-lint.yml

@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@4
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
       - name: Install Apt-Get Dependencies

.github/workflows/yaml-lint.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@4
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
       - name: Lint Workflow YAML

tests/check_pip

@@ -133,10 +133,9 @@ check_command pip ;
 if command -v pip-audit >/dev/null 2>&1; then
 	check_command pip-audit  # optional
 else
-	printf "%s\n" "::notice file=${SCRIPT_FILE},line=${BASH_LINENO:-0},title=SKIP::pip-audit not found, skipping security checks"
+	printf "%s\n" "::notice file=${SCRIPT_FILE},line=${BASH_LINENO:-0},title=SKIP::pip-audit not found, skipping security checks" ;
 fi
 check_command pip-licenses ;
-check_command pip-licenses ;
 check_command shlock ;
 
 # Set default exitcode to failure until sure we won't need to abort