You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 26, 2018. It is now read-only.
When using useBasename, the path in the address bar (and state) should be initialized with the basename path when the app inits. This is the behavior you got with redux-router and is also the behavior you get from Ember's router (when using their router's rootURL). This makes the association between history and state consistent from the very beginning. As it is now, the basename is only introduced into the browser history and state when the path is changed, e.g. with pushPath. (I'm using history 1.17.0 and redux-simple-router 1.0.2.
The text was updated successfully, but these errors were encountered:
Unfortunately, because of this, and the fact that the configured basename isn't available to redux-simple-router (because it's just closed over), this would require a change to rackt/history.
This is not the correct behavior from the POV of history/router, per remix-run/history#197. If the URL doesn't have the basename for some reason, it's not correct for the history to lie to you about what the basename of the current location is. You'll have to handle this redirect in userspace.
When using
useBasename
, the path in the address bar (and state) should be initialized with the basename path when the app inits. This is the behavior you got with redux-router and is also the behavior you get from Ember's router (when using their router'srootURL
). This makes the association between history and state consistent from the very beginning. As it is now, the basename is only introduced into the browser history and state when the path is changed, e.g. withpushPath
. (I'm using history 1.17.0 and redux-simple-router 1.0.2.The text was updated successfully, but these errors were encountered: