Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

latest verstion 1.0.1 doesn't work with basic example: Uncaught TypeError: syncHistory is not a function #157

Closed
svnm opened this issue Jan 4, 2016 · 4 comments

Comments

@svnm
Copy link
Contributor

svnm commented Jan 4, 2016

I have just tested the basic example, installing the latest version "redux-simple-router": "1.0.1"

It gives the following error: Uncaught TypeError: syncHistory is not a function

It seems that the lib from version 1.0.1 is not up to date with the current src. If I run npm run build and then use index.js from lib, it works fine.

I can see in the following commit: this is where syncReduxAndRouter function has changed to syncHistory: 6fc6ab7#diff-1fdf421c05c1140f6d71444ea2b27638

Now that I look at the latest published date on npm is 2 weeks ago, so obviously this recent version is not published. Can we publish it as soon as its all good and tested, otherwise the basic example is incorrect at the moment.

Thanks

@svnm svnm changed the title npm version 1.0.1 not up to date with basic example: npm: Uncaught TypeError: syncHistory is not a function current version does not work with basic example: npm: Uncaught TypeError: syncHistory is not a function Jan 4, 2016
@svnm svnm changed the title current version does not work with basic example: npm: Uncaught TypeError: syncHistory is not a function latest verstion 1.0.1 doesn't work with basic example: Uncaught TypeError: syncHistory is not a function Jan 4, 2016
@kimjoar
Copy link
Collaborator

kimjoar commented Jan 4, 2016

Here's the example for the 1.0.2 tag: https://github.com/rackt/redux-simple-router/tree/1.0.2/examples/basic

(The example in master has changed, as we're working on ideas for 2.0)

@kimjoar kimjoar closed this as completed Jan 4, 2016
@svnm
Copy link
Contributor Author

svnm commented Jan 4, 2016

cool thanks.

If version 1.0.2 is the current stable version, maybe the basic example should stay up to date with it similar to as you mentioned the README is still for 1.0.2. Just as its the official example people will start off with. I'm not sure, I just imagine lots of people running into this issue and also the pushPath() issue while you are working on 2.0

Actually maybe a note on the basic example README pointing to the 1.0.2 tag while 2.0 is being developed could solve the problem easier.

Anyways thanks for that, I will keep using 1.0.2 for now

@timjackleus
Copy link

I'm trying to to get started with the basic example as well but stuck with the same error (Uncaught TypeError: syncHistory) even on 1.0.2.

@ChristopherRabotin
Copy link

@timjackleus there is no syncHistory in the basic example linked above. Check that you don't have old code lying around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants