Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Not compatible with IE8 (ES3) #332

Closed
ctumolosus opened this issue Mar 18, 2016 · 4 comments · Fixed by #344
Closed

Not compatible with IE8 (ES3) #332

ctumolosus opened this issue Mar 18, 2016 · 4 comments · Fixed by #344

Comments

@ctumolosus
Copy link
Contributor

The output in ./lib is not compatible with IE8 due to usage of unquoted reserved keys (e.g. export.default should be export['default']). I forked the repo hoping that I could fix it using babel-plugin-transform-es3-property-literals and babel-plugin-transform-es3-member-expression-literals but as this thread indicates it doesn't solve the issue: https://phabricator.babeljs.io/T2817. It seems using es3ify is a workaround for now. I can transform your package at build time on my end, but I wonder if it's something that should be addressed here instead.

@SimenB
Copy link
Contributor

SimenB commented Mar 19, 2016

The bugs in the es3 transforms are fixed

@ctumolosus
Copy link
Contributor Author

Hi @SimenB, I'm still experiencing issues with the plugins. I have committed my changes to https://github.com/ctumolosus/react-router-redux if you would like to take a look.

The issue is that syncHistoryWithStore is transformed to exports.default = syncHistoryWithStore; instead of exports['default'] = syncHistoryWithStore;.

@timdorr
Copy link
Member

timdorr commented Mar 21, 2016

I should just be able to rebuild against a newer Babel and we'll be all good. I'll try to get to that soon.

@ctumolosus
Copy link
Contributor Author

@timdorr I bumped babel and created a PR for your review. The issue was fixed in their latest release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants