-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Sandpack examples with index.html files throw runtime errors #6487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
* fix(sandpack-template): use custom react sandpack template * refactor: Remove console.log statement Remove console.log(filePath); from createFileMap.ts * style: Update file paths in Sandpack components Update file paths in Sandpack components to use root folder and variables
Taking a look at this. |
I opened a PR to revert the breaking change. The cause is the assumption here that all files within a sandpack example should be nested into a react.dev/src/components/MDX/Sandpack/createFileMap.ts Lines 7 to 12 in e3c25d1
This breaks examples that use
That gives us a couple options for a solution.
At this point unfortunately I think option 2 is the un-sexy, more-correct option. |
The issue seems to be because the
index.html
files defined in these examples are not used, instead, thepublic/index.html
defined in the template are usedThe text was updated successfully, but these errors were encountered: