Skip to content

[Bug]: all new sandboxes (with ShowRenderedHTML) break #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tdd opened this issue Feb 6, 2024 · 2 comments · Fixed by #6613
Closed

[Bug]: all new sandboxes (with ShowRenderedHTML) break #6612

tdd opened this issue Feb 6, 2024 · 2 comments · Fixed by #6613
Assignees
@mattcarrollcode
Labels
bug: unconfirmed

Comments

@tdd
Copy link
Contributor

tdd commented Feb 6, 2024

Summary

Pretty much all new sandboxes break in last week's work. Noticed this on yesterday's weekly translation sync.

Every single sandbox with this component breaks. I included just one example page.

Page

https://react.dev/reference/react-dom/components/link#linking-to-related-resources

Details

Capture d’écran 2024-02-06 à 09 44 28
@rickhanlonii
Copy link
Member

I think this was broken in #6496

cc @mattcarrollcode @geeseyj

@mattcarrollcode mattcarrollcode self-assigned this Feb 6, 2024
@mattcarrollcode
Copy link
Contributor

Thanks for the bug report @tdd ! I'm looking into it now. Seems like the problematic component is SandpackWithHTMLOutput

@mattcarrollcode mattcarrollcode mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattcarrollcode mattcarrollcode

Labels
bug: unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SandpackWithHTMLOutput to use src dir mattcarrollcode/reactjs.org
3 participants
@tdd @rickhanlonii @mattcarrollcode