Skip to content

[Bug]: When viewing information in Korean using Chrome at 100% resolution [1920, 953], there is a bug where the top navigation text appears as two lines. #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohe1013 opened this issue May 21, 2024 · 0 comments · Fixed by #6888

Comments

@ohe1013
Copy link
Contributor

ohe1013 commented May 21, 2024

Summary

Summary

When viewing information in Korean using Chrome at 100% resolution [1920, 953], there is a bug where the top navigation text appears as two lines.

The bug occurs from 1919px to 1990px.
🤔It seems to be a problem that occurs when 1919px's media query, existing CSS, and Korean language meet.
😀I am posting this report because I think similar bugs may occur when other languages, even if not Korean, meet.

Checked in chrome, edge, and firefox.

Page

https://ko.react.dev/

Details

Details

Bug Report

Screen enlargement 90% (normal)

90%정상

Screen enlargement 100% (abnormal)

100%버그

Screen enlargement 100% (normal)

110%정상

Environmental information, including operating system and browser information
Windows 10, crhome 124.0.6367.208

Feature Request

as-is

function NavItem({url, isActive, children}: any) {
  return (
    <div className="flex flex-auto">
      <Link
        href={url}
        className={cn(
          'active:scale-95 transition-transform w-full text-center outline-link py-1.5 px-1.5 xs:px-3 sm:px-4 rounded-full capitalize',
          !isActive && 'hover:bg-primary/5 hover:dark:bg-primary-dark/5',
          isActive &&
            'bg-highlight dark:bg-highlight-dark text-link dark:text-link-dark'
        )}>
        {children}
      </Link>
    </div>
  );
}

to-be Add text-nowrap to className of to-be Link

function NavItem({url, isActive, children}: any) {
  return (
    <div className="flex flex-auto">
      <Link
        href={url}
         // this line's text-nowrap
        className={cn(
          'active:scale-95 transition-transform w-full text-center outline-link py-1.5 px-1.5 xs:px-3 sm:px-4 rounded-full capitalize text-nowrap',
          !isActive && 'hover:bg-primary/5 hover:dark:bg-primary-dark/5',
          isActive &&
            'bg-highlight dark:bg-highlight-dark text-link dark:text-link-dark'
        )}>
        {children}
      </Link>
    </div>
  );
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant