Fix incorrect condition in "Chains of computations" example #8109
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8097
Problem
In the "Chains of computations" section, the refactored example uses an incorrect condition that changes the game logic from the original:
This allows 5 gold cards before advancing the round, which differs from the original Effect-based example that advances after 4 gold cards.
Solution
Changed the condition from
<=to<:Why This Fix is Correct
The original "bad" example increments first, then checks:
This advances after 4 cards (when count reaches 4).
The fixed example checks before incrementing:
<= 3: Allows counts 0,1,2,3 to increment → 4 values → advances on 5th card ❌< 3: Allows counts 0,1,2 to increment → 3 values → advances on 4th card ✅Testing
Verified the fix by:
Changes
src/content/learn/you-might-not-need-an-effect.mdgoldCardCount <= 3→goldCardCount < 3