Skip to content

Commit 5c12f9b

Browse files
authored
Merge pull request #50 from clue-labs/cleanup
Remove now unneeded buffer workaround for legacy PHP < 5.4
2 parents 3b8790d + ce1132c commit 5c12f9b

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/Process.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,6 @@ public function start(LoopInterface $loop, $interval = 0.1)
130130
$this->stdout->on('close', $streamCloseHandler);
131131
$this->stderr = new ReadableResourceStream($this->pipes[2], $loop);
132132
$this->stderr->on('close', $streamCloseHandler);
133-
134-
// legacy PHP < 5.4 SEGFAULTs for unbuffered, non-blocking reads
135-
// work around by enabling read buffer again
136-
if (PHP_VERSION_ID < 50400) {
137-
stream_set_read_buffer($this->pipes[1], 1);
138-
stream_set_read_buffer($this->pipes[2], 1);
139-
}
140133
}
141134

142135
/**

0 commit comments

Comments
 (0)