Cancel pending promises in race/some/any once the output promise resolves

Author: jsor

src/functions.php

@@ -51,8 +51,18 @@ function race($promisesOrValues)
                 foreach ($array as $promiseOrValue) {
                     $cancellationQueue->enqueue($promiseOrValue);
 
+                    $fulfiller = function ($value) use ($cancellationQueue, $resolve) {
+                        $cancellationQueue();
+                        $resolve($value);
+                    };
+
+                    $rejecter = function ($reason) use ($cancellationQueue, $reject) {
+                        $cancellationQueue();
+                        $reject($reason);
+                    };
+
                     resolve($promiseOrValue)
-                        ->done($resolve, $reject, $notify);
+                        ->done($fulfiller, $rejecter, $notify);
                 }
             }, $reject, $notify);
     }, $cancellationQueue);
@@ -86,14 +96,15 @@ function some($promisesOrValues, $howMany)
                 $reasons   = [];
 
                 foreach ($array as $i => $promiseOrValue) {
-                    $fulfiller = function ($val) use ($i, &$values, &$toResolve, $toReject, $resolve) {
+                    $fulfiller = function ($val) use ($i, &$values, &$toResolve, $toReject, $resolve, $cancellationQueue) {
                         if ($toResolve < 1 || $toReject < 1) {
                             return;
                         }
 
                         $values[$i] = $val;
 
                         if (0 === --$toResolve) {
+                            $cancellationQueue();
                             $resolve($values);
                         }
                     };

tests/FunctionAnyTest.php

@@ -153,4 +153,24 @@ public function shouldCancelInputArrayPromises()
 
         any([$mock1, $mock2])->cancel();
     }
+
+    /** @test */
+    public function shouldCancelOtherPendingInputArrayPromisesIfOnePromiseFulfills()
+    {
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->never())
+            ->method('__invoke');
+
+
+        $deferred = New Deferred($mock);
+        $deferred->resolve();
+
+        $mock2 = $this->getMock('React\Promise\CancellablePromiseInterface');
+        $mock2
+            ->expects($this->once())
+            ->method('cancel');
+
+        some([$deferred->promise(), $mock2], 1)->cancel();
+    }
 }

tests/FunctionRaceTest.php

@@ -160,4 +160,42 @@ public function shouldCancelInputArrayPromises()
 
         race([$mock1, $mock2])->cancel();
     }
+
+    /** @test */
+    public function shouldCancelOtherPendingInputArrayPromisesIfOnePromiseFulfills()
+    {
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->never())
+            ->method('__invoke');
+
+        $deferred = New Deferred($mock);
+        $deferred->resolve();
+
+        $mock2 = $this->getMock('React\Promise\CancellablePromiseInterface');
+        $mock2
+            ->expects($this->once())
+            ->method('cancel');
+
+        race([$deferred->promise(), $mock2])->cancel();
+    }
+
+    /** @test */
+    public function shouldCancelOtherPendingInputArrayPromisesIfOnePromiseRejects()
+    {
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->never())
+            ->method('__invoke');
+
+        $deferred = New Deferred($mock);
+        $deferred->reject();
+
+        $mock2 = $this->getMock('React\Promise\CancellablePromiseInterface');
+        $mock2
+            ->expects($this->once())
+            ->method('cancel');
+
+        race([$deferred->promise(), $mock2])->cancel();
+    }
 }

tests/FunctionSomeTest.php

@@ -165,4 +165,24 @@ public function shouldCancelInputArrayPromises()
 
         some([$mock1, $mock2], 1)->cancel();
     }
+
+    /** @test */
+    public function shouldCancelOtherPendingInputArrayPromisesIfEnoughPromisesFulfill()
+    {
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->never())
+            ->method('__invoke');
+
+
+        $deferred = New Deferred($mock);
+        $deferred->resolve();
+
+        $mock2 = $this->getMock('React\Promise\CancellablePromiseInterface');
+        $mock2
+            ->expects($this->once())
+            ->method('cancel');
+
+        some([$deferred->promise(), $mock2], 1)->cancel();
+    }
 }