Merge branch 'develop' into issue-281

Author: chocolatkey

CHANGELOG.md

@@ -4,11 +4,19 @@ All notable changes to this project will be documented in this file.
 
 **Warning:** Features marked as *alpha* may change or be removed in a future release without notice. Use with caution.
 
-## Unreleased
+## [0.13.3] - 2026-02-27
+
+### Fixed
+
+- The `ConformsTo` function on manifests (and by extension, publications) mistakenly checked the manifest's `links`, not its `readingOrder`, for mediatypes that determine whether the manifest is conforming to a certain profile. This may have caused mistaken cases of a11y inferrence or Divina/Audiobook/EPUB/PDF profile detection.
+
+## [0.13.2] - 2026-02-26
 
 ### Fixed
 
 - Fixed a typo in the accessibility metadata (`describeMath` should be `describedMath`).
+- File fetcher (for exploded local publications) would panic due to runtime cleanup bug
+- Fetcher for archives and exploded publications were [not able to retrieve resources at paths containing special characters](https://github.com/readium/cli/issues/94), such as spaces
 
 ## [0.13.1] - 2025-12-08
 

pkg/fetcher/fetcher_archive.go

@@ -44,7 +44,14 @@ func (f *ArchiveFetcher) Links(ctx context.Context) (manifest.LinkList, error) {
 
 // Get implements Fetcher
 func (f *ArchiveFetcher) Get(ctx context.Context, link manifest.Link) Resource {
-	entry, err := f.archive.Entry(link.Href.String())
+	// use decoded path for archive entry lookup to support files with spaces and special characters
+	var entryPath string
+	if hrefURL := link.Href.Resolve(nil, nil); hrefURL != nil {
+		entryPath = hrefURL.Path()
+	} else {
+		entryPath = link.Href.String()
+	}
+	entry, err := f.archive.Entry(entryPath)
 	if err != nil {
 		return NewFailureResource(link, NotFound(err))
 	}

pkg/fetcher/fetcher_file.go

@@ -79,7 +79,13 @@ func (f *FileFetcher) Links(ctx context.Context) (manifest.LinkList, error) {
 
 // Get implements Fetcher
 func (f *FileFetcher) Get(ctx context.Context, link manifest.Link) Resource {
-	linkHref := link.Href.String()
+	// use decoded path for local file lookup to support files with spaces and special characters
+	var linkHref string
+	if hrefURL := link.Href.Resolve(nil, nil); hrefURL != nil {
+		linkHref = hrefURL.Path()
+	} else {
+		linkHref = link.Href.String()
+	}
 	for itemHref, itemFile := range f.paths {
 		if strings.HasPrefix(linkHref, itemHref) {
 			resourceFile := filepath.Join(itemFile, strings.TrimPrefix(linkHref, itemHref))
@@ -169,7 +175,6 @@ func (r *FileResource) open() (*os.File, *ResourceError) {
 	r.file = f
 	runtime.AddCleanup(r, func(f *os.File) {
 		f.Close()
-		r.file = nil
 	}, f)
 	return f, nil
 }

pkg/manifest/manifest.go

@@ -31,16 +31,16 @@ func (m Manifest) ConformsTo(profile Profile) bool {
 
 	switch profile {
 	case ProfileAudiobook:
-		return m.Links.AllAreAudio()
+		return m.ReadingOrder.AllAreAudio()
 	case ProfileDivina:
-		return m.Links.AllAreBitmap()
+		return m.ReadingOrder.AllAreBitmap()
 	case ProfileEPUB:
 		// EPUB needs to be explicitly indicated in `conformsTo`, otherwise it could be a regular Web Publication.
 		if slices.Contains(m.Metadata.ConformsTo, ProfileEPUB) && m.ReadingOrder.AllAreHTML() {
 			return true
 		}
 	case ProfilePDF:
-		return m.Links.AllMatchMediaType(&mediatype.PDF)
+		return m.ReadingOrder.AllMatchMediaType(&mediatype.PDF)
 	default:
 		if slices.Contains(m.Metadata.ConformsTo, profile) {
 			return true