readyset-client: allow ADD INDEX to not require resnapshot

This commit allows the `ADD INDEX` statement to not require a
resnapshot.
Those operations will not change the underlying table, so we can avoid
the resnapshot.
This is not the case for ADD PRIMARY KEY & ADD UNIQUE KEY.

Change-Id: I66792a6fc57affb44c946816ef10993a11c30730
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/9595
Tested-by: Buildkite CI
Reviewed-by: Michael Zink <michael.z@readyset.io>

Author: altmannmarcelo

readyset-client/src/recipe/changelist.rs

@@ -41,7 +41,7 @@ use readyset_errors::{internal, unsupported, ReadySetError, ReadySetResult};
 use readyset_sql::ast::{
     AlterTableDefinition, AlterTableStatement, CacheInner, CreateCacheStatement,
     CreateTableStatement, CreateViewStatement, DropTableStatement, DropViewStatement,
-    NonReplicatedRelation, Relation, SelectStatement, SqlIdentifier, SqlQuery,
+    NonReplicatedRelation, Relation, SelectStatement, SqlIdentifier, SqlQuery, TableKey,
 };
 use readyset_sql_parsing::parse_query;
 use readyset_sql_passes::adapter_rewrites::{self, AdapterRewriteParams};
@@ -393,10 +393,15 @@ impl Change {
                         | AlterTableDefinition::DropColumn { .. }
                         | AlterTableDefinition::ChangeColumn { .. }
                         | AlterTableDefinition::RenameColumn { .. }
-                        | AlterTableDefinition::AddKey(_)
+                        | AlterTableDefinition::AddKey(TableKey::PrimaryKey { .. })
+                        | AlterTableDefinition::AddKey(TableKey::UniqueKey { .. })
                         | AlterTableDefinition::DropForeignKey { .. }
                         | AlterTableDefinition::DropConstraint { .. } => true,
-                        AlterTableDefinition::ReplicaIdentity(_) => false,
+                        AlterTableDefinition::ReplicaIdentity(_)
+                        | AlterTableDefinition::AddKey(TableKey::FulltextKey { .. })
+                        | AlterTableDefinition::AddKey(TableKey::Key { .. })
+                        | AlterTableDefinition::AddKey(TableKey::CheckConstraint { .. })
+                        | AlterTableDefinition::AddKey(TableKey::ForeignKey { .. }) => false,
                     })
                 } else {
                     // We know it's an alter table, but we couldn't fully parse it.