psql-srv: Use optimized date+time encoding

This commit replaces our usage of chrono's `format()` methods with our
handwritten optimized encoding algorithms in psql-srv in the code we use
to encode rows before sending them over the wire. This significantly
improves warm read time for queries that include timestamps in their
result sets.

Release-Note-Core: Significantly improved warm read performance for
  certain queries that return timestamps
Change-Id: I4b1158b20d9052bae204b6b1584b6020d8fd504a
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/7221
Reviewed-by: Luke Osborne <luke@readyset.io>
Tested-by: Buildkite CI

Author: ethowitz

Cargo.lock

@@ -40,6 +40,7 @@ uuid = "0.8"
 nom-sql = { path = "../nom-sql" }
 readyset-adapter-types = { path = "../readyset-adapter-types" }
 readyset-data = { path = "../readyset-data" }
+readyset-util = { path = "../readyset-util" }
 
 [dev-dependencies]
 tokio = { workspace = true, features = ["full"] }

psql-srv/Cargo.toml

@@ -4,6 +4,7 @@ use bytes::{BufMut, BytesMut};
 use eui48::MacAddressFormat;
 use postgres::error::ErrorPosition;
 use postgres_types::{ToSql, Type};
+use readyset_util::fmt::FastEncode;
 use tokio_util::codec::Encoder;
 
 use crate::codec::error::EncodeError as Error;
@@ -76,10 +77,6 @@ const LENGTH_NULL_SENTINEL: i32 = -1;
 const LENGTH_PLACEHOLDER: i32 = -1;
 const NUL_BYTE: u8 = b'\0';
 const NUL_CHAR: char = '\0';
-const TIMESTAMP_FORMAT: &str = "%Y-%m-%d %H:%M:%S%.f";
-const TIMESTAMP_TZ_FORMAT: &str = "%Y-%m-%d %H:%M:%S%.f %:z";
-const TIME_FORMAT: &str = "%H:%M:%S%.f";
-const DATE_FORMAT: &str = "%Y-%m-%d";
 
 impl Encoder<BackendMessage> for Codec {
     type Error = Error;
@@ -647,18 +644,18 @@ fn put_text_value(val: PsqlValue, dst: &mut BytesMut) -> Result<(), Error> {
         PsqlValue::Timestamp(v) => {
             // TODO: Does not correctly handle all valid timestamp representations. For example,
             // 8601/SQL timestamp format is assumed; infinity/-infinity are not supported.
-            write!(dst, "{}", v.format(TIMESTAMP_FORMAT))?;
+            v.put(dst);
         }
         PsqlValue::TimestampTz(v) => {
             // TODO: Does not correctly handle all valid timestamp representations. For example,
             // 8601/SQL timestamp format is assumed; infinity/-infinity are not supported.
-            write!(dst, "{}", v.format(TIMESTAMP_TZ_FORMAT))?;
+            v.put(dst);
         }
         PsqlValue::Date(v) => {
-            write!(dst, "{}", v.format(DATE_FORMAT))?;
+            v.put(dst);
         }
         PsqlValue::Time(v) => {
-            write!(dst, "{}", v.format(TIME_FORMAT))?;
+            v.put(dst);
         }
         PsqlValue::ByteArray(b) => {
             write!(
@@ -1644,22 +1641,6 @@ mod tests {
         assert_eq!(buf, exp);
     }
 
-    #[test]
-    fn test_encode_text_timestamp() {
-        let mut buf = BytesMut::new();
-        put_text_value(
-            PsqlValue::Timestamp(
-                NaiveDateTime::parse_from_str("2020-01-02 03:04:05.660", TIMESTAMP_FORMAT).unwrap(),
-            ),
-            &mut buf,
-        )
-        .unwrap();
-        let mut exp = BytesMut::new();
-        exp.put_i32(23); // length
-        exp.extend_from_slice(b"2020-01-02 03:04:05.660"); // value
-        assert_eq!(buf, exp);
-    }
-
     #[test]
     fn test_encode_text_bytea() {
         let mut buf = BytesMut::new();
@@ -1735,20 +1716,4 @@ mod tests {
         put_text_value(PsqlValue::Bit(bits), &mut buf).unwrap();
         assert_eq!(buf, exp);
     }
-
-    #[test]
-    fn test_encode_text_timestamp_tz() {
-        let dt = FixedOffset::east_opt(18000)
-            .unwrap()
-            .from_utc_datetime(&NaiveDateTime::new(
-                NaiveDate::from_ymd_opt(2020, 1, 2).unwrap(),
-                NaiveTime::from_hms_milli_opt(3, 4, 5, 660).unwrap(),
-            ));
-        let mut buf = BytesMut::new();
-        put_text_value(PsqlValue::TimestampTz(dt), &mut buf).unwrap();
-        let mut exp = BytesMut::new();
-        exp.put_i32(30);
-        exp.extend_from_slice(b"2020-01-02 08:04:05.660 +05:00");
-        assert_eq!(buf, exp);
-    }
 }