readyset-data: Handle parsing and returning more invalid dates

A schema with a DEFAULT '0000-00-00 00:00:00' revealed another parsing
location that needed to take invalid dates into account.

Release-Note-Core: Handle invalid '0000-00-00 00:00:00' date when it
  appears as as a default column value in the schema.
Change-Id: I676f9e8c4af8c1fbb4df8be78f7741e5c127590d
Reviewed-on: https://gerrit.readyset.name/c/readyset/+/9079
Reviewed-by: Marcelo Altmann <marcelo@readyset.io>
Tested-by: Buildkite CI

Author: rs-sac

readyset-data/src/timestamp.rs

@@ -7,7 +7,7 @@ use chrono::{
     DateTime, Datelike, FixedOffset, NaiveDate, NaiveDateTime, NaiveTime, TimeZone, Timelike,
 };
 use proptest::arbitrary::Arbitrary;
-use readyset_errors::{internal_err, ReadySetError, ReadySetResult};
+use readyset_errors::{internal, internal_err, ReadySetError, ReadySetResult};
 use serde::{Deserialize, Serialize};
 
 use crate::{DfType, DfValue};
@@ -24,6 +24,9 @@ pub const TIMESTAMP_TZ_FORMAT: &str = "%Y-%m-%d %H:%M:%S%:z";
 /// The format for dates when parsed as text
 pub const DATE_FORMAT: &str = "%Y-%m-%d";
 
+/// The format for times when parsed as text
+pub const TIME_PARSE_FORMAT: &str = "%H:%M:%S%.f";
+
 /// An optimized storage for date and datetime SQL formats. The possible inner data
 /// may be:
 ///
@@ -397,12 +400,29 @@ impl TimestampTz {
                 }
             } else if let Ok(dt) = NaiveDateTime::parse_from_str(ts, TIMESTAMP_PARSE_FORMAT) {
                 dt.into()
-            } else {
+            } else if let Ok(dt) = NaiveDate::parse_from_str(ts, DATE_FORMAT) {
                 // Make TimestampTz object with time portion 00:00:00
-                NaiveDate::parse_from_str(ts, DATE_FORMAT)?
-                    .and_hms_opt(0, 0, 0)
+                dt.and_hms_opt(0, 0, 0)
                     .ok_or(internal_err!("Invalid date format"))?
                     .into()
+            } else if ts.starts_with("+0000-00-00") {
+                const ZERO_TIME: NaiveTime = NaiveTime::from_hms_opt(0, 0, 0).unwrap();
+                match ts.split_once(' ') {
+                    None | Some((_, "")) => Self::zero(),
+                    Some((_, time)) => {
+                        if let Ok(time) = NaiveTime::parse_from_str(time, TIME_PARSE_FORMAT) {
+                            if time == ZERO_TIME {
+                                Self::zero()
+                            } else {
+                                internal!("Invalid date format")
+                            }
+                        } else {
+                            internal!("Invalid date format")
+                        }
+                    }
+                }
+            } else {
+                internal!("Invalid date format")
             },
         )
     }