Skip to content

Commit c9dfb64

Browse files
committed
buildkite: Fix bug retrieving artifacts from matrixed steps
If a step is matrixed, there will be a single step key for multiple jobs. Since those jobs may all produce artifacts with the same name, the step key is insufficient to identify jobs from which we should retrieve artifacts. This update modifies the query to return job ids and labels of matching steps, filters the jobs for ones that match the current label, and uses the job id instead of step name for downloading the artifacts. Change-Id: I6a6a6964cd8759cd393589c337e046f051cc324f Reviewed-on: https://gerrit.readyset.name/c/readyset/+/10230 Reviewed-by: Michael Zink <michael.z@readyset.io> Tested-by: Buildkite CI
1 parent fd8487c commit c9dfb64

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.buildkite/pipeline.public-common.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ steps:
105105
- BUILDKITE_PIPELINE_SLUG
106106
- BUILDKITE_BRANCH
107107
- BUILDKITE_STEP_KEY
108+
- BUILDKITE_LABEL
108109
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
109110
- SCCACHE_REGION=us-east-2
110111
- CARGO_INCREMENTAL=0
@@ -167,6 +168,7 @@ steps:
167168
- BUILDKITE_PIPELINE_SLUG
168169
- BUILDKITE_BRANCH
169170
- BUILDKITE_STEP_KEY
171+
- BUILDKITE_LABEL
170172
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
171173
- SCCACHE_REGION=us-east-2
172174
- CARGO_INCREMENTAL=0
@@ -212,6 +214,7 @@ steps:
212214
- BUILDKITE_PIPELINE_SLUG
213215
- BUILDKITE_BRANCH
214216
- BUILDKITE_STEP_KEY
217+
- BUILDKITE_LABEL
215218
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
216219
- SCCACHE_REGION=us-east-2
217220
- CARGO_INCREMENTAL=0

0 commit comments

Comments
 (0)