Skip to content

Commit b38a156

Browse files
authored
[EarlyReturn] Only check on loop when initialAssign is set on PreparedValueToEarlyReturnRector (#6868)
1 parent d025cdd commit b38a156

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rules/EarlyReturn/Rector/Return_/PreparedValueToEarlyReturnRector.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,12 @@ public function refactor(Node $node): ?StmtsAwareInterface
110110
return null;
111111
}
112112

113-
if ($stmt instanceof For_ || $stmt instanceof Foreach_ || $stmt instanceof While_ || $stmt instanceof Do_) {
113+
if (($stmt instanceof For_ || $stmt instanceof Foreach_ || $stmt instanceof While_ || $stmt instanceof Do_) && $initialAssign instanceof Assign) {
114114
$isReassignInLoop = (bool) $this->betterNodeFinder->findFirst(
115115
$stmt,
116116
fn (Node $node): bool => $node instanceof Assign && $this->nodeComparator->areNodesEqual(
117117
$node->var,
118-
$initialAssign?->var
118+
$initialAssign->var
119119
)
120120
);
121121

0 commit comments

Comments
 (0)