Commit c64eace
feat: KEP-2437 - PodGroup Creation for Volcano Scheduler (kubeflow#2729)
* feat: api for volcano scheduling plugin
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: init volcano-plugin
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: init test file
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: register volcano plugin
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: deal with minTaskMember, minMember, NetworkTopo
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: calculate of minResource
Signed-off-by: Xinmin Du <2812493086@qq.com>
* test: build PodGroup test
Signed-off-by: Xinmin Du <2812493086@qq.com>
* refactor: separate to 2 prs(build&handler)
Signed-off-by: Xinmin Du <2812493086@qq.com>
* test: add test for new&reconcile_builder
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: typo
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: trainer/v2 import
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: networktopo type
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: OpenAPI validation errors
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: remove minTaskMembers
Signed-off-by: Xinmin Du <2812493086@qq.com>
* test: test coverage 100%
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: update apis
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: replace testify
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: registry Volcano CRDs to the scheme
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: add volcano to scheme
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: fix networktopo schema
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: add networktopo spec in trainer
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: unit test
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: import networkTopo directly
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: make generate
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: make generate
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: golangci-lint
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: golangci-lint
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: add volcano installation in integration test
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: filter volcano api
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: get volcano.podgroup with local version
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: init test env with volcano podgroup installed
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: check plugin in enforcePodgroupPolicy
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: group-name label in unit test
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: ReconcilerBuilders
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: add PodGroupHandler
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: unit test for handlers
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: group name annotation
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update hack/swagger/main.go
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: no need to delete RBAC
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update pkg/runtime/framework/plugins/volcano/indexer.go
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: nil checking for trainjob
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update pkg/runtime/framework/plugins/volcano/volcano.go
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: make generate
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: index conflict
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update pkg/runtime/framework/plugins/coscheduling/coscheduling.go
Co-authored-by: Shao Wang <2690692950@qq.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: update volcano to v1.12.2
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: re-use indexer
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: add validate
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: no scheduler when coscheduling is nil
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: put group-name in annotations
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: validate if priorityClass installed
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: propagate annotations to pod
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: integration test for volcano
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: golangci-lint check
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: use shared indexer
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: remove indexer to runtime/
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update hack/swagger/main.go
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* Update hack/swagger/main.go
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: append owner reference & missing import
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: rewrite volcano UT
Signed-off-by: Xinmin Du <2812493086@qq.com>
* feat: add copyright
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: sync RBAC to Helm charts
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: refactor UTs
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: test validation separately
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update hack/swagger/main.go
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
* fix: refactor TestVolcano
Signed-off-by: Xinmin Du <2812493086@qq.com>
* fix: refactor TestValidate
Signed-off-by: Xinmin Du <2812493086@qq.com>
* Update pkg/runtime/framework/plugins/volcano/volcano_test.go
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
---------
Signed-off-by: Xinmin Du <2812493086@qq.com>
Signed-off-by: Du Xinmin <2812493086@qq.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Co-authored-by: Shao Wang <2690692950@qq.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>1 parent 56ab163 commit c64eace
43 files changed
Lines changed: 3168 additions & 415 deletions
File tree
- api
- openapi-spec
- python_api/kubeflow_trainer_api/models
- charts/kubeflow-trainer
- crds
- templates/rbac
- cmd/trainer-controller-manager
- hack
- swagger
- manifests/base
- crds
- rbac
- pkg
- apis/trainer/v1alpha1
- client/applyconfiguration
- trainer/v1alpha1
- runtime
- framework
- core
- plugins
- coscheduling
- jobset
- volcano
- indexer
- util/testing
- test/integration/framework
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
114 | 123 | | |
115 | 124 | | |
116 | 125 | | |
| |||
155 | 164 | | |
156 | 165 | | |
157 | 166 | | |
158 | | - | |
| 167 | + | |
159 | 168 | | |
160 | 169 | | |
161 | 170 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 89 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 91 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
627 | 627 | | |
628 | 628 | | |
629 | 629 | | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
630 | 653 | | |
631 | 654 | | |
632 | 655 | | |
| |||
0 commit comments