Skip to content

Commit f169476

Browse files
kramaranyaalexxfan
authored andcommitted
fix: update kubeflow sdk reference (kubeflow#2780)
Signed-off-by: kramaranya <kramaranya15@gmail.com>
1 parent 0ffa996 commit f169476

7 files changed

Lines changed: 21 additions & 31 deletions

File tree

.github/workflows/test-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
pip install papermill==2.6.0 jupyter==1.1.1 ipykernel==6.29.5
4242
4343
echo "Install Kubeflow SDK"
44-
pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python
44+
pip install git+https://github.com/kubeflow/sdk.git@main
4545
4646
- name: Setup cluster
4747
run: |

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,4 +135,4 @@ On ubuntu the default go package appears to be gccgo-go which has problems. It's
135135

136136
Changes to the Kubeflow Trainer Python SDK can be made in the https://github.com/kubeflow/sdk repo.
137137

138-
The Trainer SDK can be found at https://github.com/kubeflow/sdk/tree/main/python/kubeflow/trainer.
138+
The Trainer SDK can be found at https://github.com/kubeflow/sdk/tree/main/kubeflow/trainer.

examples/deepspeed/text-summarization/T5-Fine-Tuning.ipynb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@
3535
"id": "4900404c5d532bdf",
3636
"metadata": {},
3737
"outputs": [],
38-
"source": [
39-
"# !pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python"
40-
]
38+
"source": "# !pip install git+https://github.com/kubeflow/sdk.git@main"
4139
},
4240
{
4341
"cell_type": "markdown",

examples/mlx/image-classification/MLX-Distributed-Mnist.ipynb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@
8282
"id": "bd62189280760f42",
8383
"metadata": {},
8484
"outputs": [],
85-
"source": [
86-
"# !pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python"
87-
]
85+
"source": "# !pip install git+https://github.com/kubeflow/sdk.git@main"
8886
},
8987
{
9088
"cell_type": "markdown",

examples/pytorch/image-classification/mnist.ipynb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@
3131
"execution_count": null,
3232
"metadata": {},
3333
"outputs": [],
34-
"source": [
35-
"# !pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python"
36-
]
34+
"source": "# !pip install git+https://github.com/kubeflow/sdk.git@main"
3735
},
3836
{
3937
"cell_type": "markdown",

examples/pytorch/question-answering/fine-tune-distilbert.ipynb

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@
3838
"id": "e5e86ea307b3eec9",
3939
"metadata": {},
4040
"outputs": [],
41-
"source": [
42-
"# !pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python"
43-
]
41+
"source": "# !pip install git+https://github.com/kubeflow/sdk.git@main"
4442
},
4543
{
4644
"cell_type": "markdown",
@@ -116,8 +114,8 @@
116114
"Requirement already satisfied: pycparser in /Users/andrew/git/trainer/.venv/lib/python3.13/site-packages (from cffi>=1.12->cryptography>=2.1.4->azure-storage-blob>=12->cloudpathlib[all]) (2.22)\n",
117115
"Requirement already satisfied: pyasn1<0.7.0,>=0.6.1 in /Users/andrew/git/trainer/.venv/lib/python3.13/site-packages (from pyasn1-modules>=0.2.1->google-auth<3.0dev,>=2.26.1->google-cloud-storage->cloudpathlib[all]) (0.6.1)\n",
118116
"\n",
119-
"\u001b[1m[\u001b[0m\u001b[34;49mnotice\u001b[0m\u001b[1;39;49m]\u001b[0m\u001b[39;49m A new release of pip is available: \u001b[0m\u001b[31;49m25.0.1\u001b[0m\u001b[39;49m -> \u001b[0m\u001b[32;49m25.1\u001b[0m\n",
120-
"\u001b[1m[\u001b[0m\u001b[34;49mnotice\u001b[0m\u001b[1;39;49m]\u001b[0m\u001b[39;49m To update, run: \u001b[0m\u001b[32;49mpip install --upgrade pip\u001b[0m\n"
117+
"\u001B[1m[\u001B[0m\u001B[34;49mnotice\u001B[0m\u001B[1;39;49m]\u001B[0m\u001B[39;49m A new release of pip is available: \u001B[0m\u001B[31;49m25.0.1\u001B[0m\u001B[39;49m -> \u001B[0m\u001B[32;49m25.1\u001B[0m\n",
118+
"\u001B[1m[\u001B[0m\u001B[34;49mnotice\u001B[0m\u001B[1;39;49m]\u001B[0m\u001B[39;49m To update, run: \u001B[0m\u001B[32;49mpip install --upgrade pip\u001B[0m\n"
121119
]
122120
}
123121
],
@@ -449,21 +447,21 @@
449447
" 0%| | 0/40 [00:00<?, ?it/s][rank0]:[W429 01:22:58.895439547 reducer.cpp:1400] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters in the forward pass. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters in the forward pass, consider turning this flag off. Note that this warning may be a false positive if your model has flow control causing later iterations to have unused parameters. (function operator())\n",
450448
"[node-0]: [rank1]:[W429 01:22:58.895689005 reducer.cpp:1400] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters in the forward pass. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters in the forward pass, consider turning this flag off. Note that this warning may be a false positive if your model has flow control causing later iterations to have unused parameters. (function operator())\n",
451449
"100%|██████████| 40/40 [02:36<00:00, 4.10s/it]\n",
452-
" 0%| | 0/10 [00:00<?, ?it/s]\u001b[A\n",
453-
" 20%|██ | 2/10 [00:00<00:03, 2.54it/s]\u001b[A\n",
454-
" 30%|███ | 3/10 [00:01<00:03, 1.80it/s]\u001b[A\n",
455-
" 40%|████ | 4/10 [00:02<00:03, 1.55it/s]\u001b[A\n",
456-
" 50%|█████ | 5/10 [00:03<00:03, 1.43it/s]\u001b[A\n",
457-
" 60%|██████ | 6/10 [00:03<00:02, 1.37it/s]\u001b[A\n",
458-
" 70%|███████ | 7/10 [00:04<00:02, 1.32it/s]\u001b[A\n",
459-
" 80%|████████ | 8/10 [00:05<00:01, 1.30it/s]\u001b[A\n",
460-
" 90%|█████████ | 9/10 [00:06<00:00, 1.29it/s]\u001b[A\n",
461-
" \u001b[A\n",
450+
" 0%| | 0/10 [00:00<?, ?it/s]\u001B[A\n",
451+
" 20%|██ | 2/10 [00:00<00:03, 2.54it/s]\u001B[A\n",
452+
" 30%|███ | 3/10 [00:01<00:03, 1.80it/s]\u001B[A\n",
453+
" 40%|████ | 4/10 [00:02<00:03, 1.55it/s]\u001B[A\n",
454+
" 50%|█████ | 5/10 [00:03<00:03, 1.43it/s]\u001B[A\n",
455+
" 60%|██████ | 6/10 [00:03<00:02, 1.37it/s]\u001B[A\n",
456+
" 70%|███████ | 7/10 [00:04<00:02, 1.32it/s]\u001B[A\n",
457+
" 80%|████████ | 8/10 [00:05<00:01, 1.30it/s]\u001B[A\n",
458+
" 90%|█████████ | 9/10 [00:06<00:00, 1.29it/s]\u001B[A\n",
459+
" \u001B[A\n",
462460
"[node-0]: {'eval_loss': 5.543211936950684, 'eval_runtime': 7.9713, 'eval_samples_per_second': 2.509, 'eval_steps_per_second': 1.254, 'epoch': 1.0}\n",
463461
"100%|██████████| 40/40 [02:45<00:00, 4.10s/it]\n",
464-
"100%|██████████| 10/10 [00:07<00:00, 1.28it/s]\u001b[A\n",
462+
"100%|██████████| 10/10 [00:07<00:00, 1.28it/s]\u001B[A\n",
465463
"[node-0]: {'train_runtime': 165.12, 'train_samples_per_second': 0.484, 'train_steps_per_second': 0.242, 'train_loss': 5.764264678955078, 'epoch': 1.0}\n",
466-
"100%|██████████| 40/40 [02:45<00:00, 4.13s/it]\u001b[A\n"
464+
"100%|██████████| 40/40 [02:45<00:00, 4.13s/it]\u001B[A\n"
467465
]
468466
}
469467
],

examples/torchtune/llama3_2/alpaca-trainjob-yaml.ipynb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@
3838
"id": "288ec515",
3939
"metadata": {},
4040
"outputs": [],
41-
"source": [
42-
"!pip install git+https://github.com/kubeflow/sdk.git@main#subdirectory=python"
43-
]
41+
"source": "!pip install git+https://github.com/kubeflow/sdk.git@main"
4442
},
4543
{
4644
"cell_type": "markdown",

0 commit comments

Comments
 (0)