Skip to content

runtime-fallback-graph fails on stage 1 .NET 8 builds #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmds opened this issue Sep 1, 2023 · 3 comments · Fixed by #293
Closed

runtime-fallback-graph fails on stage 1 .NET 8 builds #289

tmds opened this issue Sep 1, 2023 · 3 comments · Fixed by #293

Comments

@tmds
Copy link
Member

tmds commented Sep 1, 2023

This test fails on a .NET 8 unknown distro build.

This is not unexpected since the runtime logic that updates the runtime graph during the build was removed.

Probably a stage 2 build will pass the test, because the rid is known by the final output of the build.
This should be verified.

Because the logic around rids has seen a major overhaul with .NET 8, we should verify how the issue that this test is guarding against is behaving with the stage 1 and stage 2 outputs.

With some recent changes (SDK switching from legacy graph to a trimmed graph), it should become so that all stage 1 builds from a Microsoft SDK are in the "previously unknown distro" case.

cc @omajid

@tmds tmds changed the title runtime-fallback-graph fails on previously unknown stage 1 .NET 8 builds runtime-fallback-graph fails on previously unknown distro stage 1 .NET 8 builds Sep 1, 2023
@tmds
Copy link
Member Author

tmds commented Sep 4, 2023

Because the logic around rids has seen a major overhaul with .NET 8, we should verify how the issue that this test is guarding against is behaving with the stage 1 and stage 2 outputs.

The information added to the runtimes section should only be used when an application explicitly opts into it.
By default, a hard coded list from the host is used instead.

@tmds tmds closed this as completed in #293 Sep 4, 2023
@tmds tmds changed the title runtime-fallback-graph fails on previously unknown distro stage 1 .NET 8 builds runtime-fallback-graph fails on stage 1 .NET 8 builds Sep 19, 2023
@omajid
Copy link
Member

omajid commented Jun 21, 2024

Any reason this wouldn't also apply to .NET 9?

@tmds
Copy link
Member Author

tmds commented Jun 21, 2024

I don't think anyone cares about fixing this, so I expect it to continue behaving like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants