chore: fix sonarcloud issues

Signed-off-by: Stephane Bouchet <[email protected]>

Author: sbouchet

src/it/java/org/jboss/tools/intellij/openshift/test/ui/AbstractBaseTest.java

@@ -14,10 +14,10 @@
 import com.intellij.remoterobot.utils.WaitForConditionTimeoutException;
 import com.redhat.devtools.intellij.commonuitest.fixtures.mainidewindow.idestatusbar.IdeStatusBar;
 import com.redhat.devtools.intellij.commonuitest.fixtures.mainidewindow.toolwindowspane.ToolWindowsPane;
+import org.jboss.tools.intellij.openshift.test.ui.annotations.UITest;
 import org.jboss.tools.intellij.openshift.test.ui.dialogs.ProjectStructureDialog;
 import org.jboss.tools.intellij.openshift.test.ui.junit.TestRunnerExtension;
 import org.jboss.tools.intellij.openshift.test.ui.runner.IdeaRunner;
-import org.jboss.tools.intellij.openshift.test.ui.annotations.UITest;
 import org.jboss.tools.intellij.openshift.test.ui.utils.ProjectUtility;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -29,7 +29,7 @@
  */
 @ExtendWith(TestRunnerExtension.class)
 @UITest
-abstract public class AbstractBaseTest {
+public abstract class AbstractBaseTest {
 
     protected static RemoteRobot robot;
 

src/it/java/org/jboss/tools/intellij/openshift/utils/helm/HelmCliTest.java

@@ -15,7 +15,6 @@
 import org.jboss.tools.intellij.openshift.utils.ToolFactory;
 import org.jboss.tools.intellij.openshift.utils.odo.Odo;
 
-
 public abstract class HelmCliTest extends BasePlatformTestCase {
 
     protected Helm helm;

src/main/java/org/jboss/tools/intellij/openshift/GettingStartedToolWindow.java

@@ -144,7 +144,7 @@ private GettingStartedGroupLessons buildOpenShiftFuncLessons() {
                 gifStartDeployLesson
         );
 
-        GettingStartedGroupLessons groupLessons = new GettingStartedGroupLessons(
+        return new GettingStartedGroupLessons(
                 "Getting Started with OpenShift Toolkit",
                 "Start your application development on OpenShift or Kubernetes",
                 loginLesson,
@@ -153,7 +153,6 @@ private GettingStartedGroupLessons buildOpenShiftFuncLessons() {
                 startDevLesson,
                 startDebugLesson,
                 startDeployLesson);
-        return groupLessons;
     }
 
     private URL getLessonGif(String name) {

src/main/java/org/jboss/tools/intellij/openshift/actions/HelmAction.java

@@ -41,19 +41,19 @@ public void actionPerformed(AnActionEvent anActionEvent, TreePath path, Object s
         if (helm == null) {
           return;
         }
-        this.actionPerformed(anActionEvent, (Object) getElement(selected), helm);
+        this.actionPerformedOnSelectedObject(anActionEvent, getElement(selected), helm);
     }
 
     private Helm getHelm(AnActionEvent anActionEvent) {
         try {
-          return ActionUtils.getApplicationRootNode(anActionEvent).getHelm(true).getNow(null);
+            return ActionUtils.getApplicationRootNode(anActionEvent).getHelm().getNow(null);
         } catch(Exception e) {
           LOGGER.warn("Could not get helm: " + e.getMessage(), e);
           return null;
         }
     }
 
-    public abstract void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Helm helm);
+    public abstract void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Helm helm);
 
     protected abstract String getTelemetryActionName();
 

src/main/java/org/jboss/tools/intellij/openshift/actions/OdoAction.java

@@ -41,7 +41,7 @@ public void actionPerformed(AnActionEvent anActionEvent, TreePath path, Object s
         if (odo == null) {
           return;
         }
-        this.actionPerformed(anActionEvent, (Object) getElement(selected), odo);
+        this.actionPerformedOnSelectedObject(anActionEvent, getElement(selected), odo);
     }
 
     private Odo getOdo(AnActionEvent anActionEvent) {
@@ -53,7 +53,7 @@ private Odo getOdo(AnActionEvent anActionEvent) {
         }
     }
 
-    public abstract void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo);
+    public abstract void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo);
 
     protected abstract String getTelemetryActionName();
 

src/main/java/org/jboss/tools/intellij/openshift/actions/OpenGettingStartedAction.java

@@ -31,7 +31,7 @@ protected String getTelemetryActionName() {
     }
 
     @Override
-    public void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
+    public void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
         Project project = anActionEvent.getProject();
         if (project == null) {
             return;

src/main/java/org/jboss/tools/intellij/openshift/actions/binding/DeleteBindingAction.java

@@ -27,7 +27,7 @@ public DeleteBindingAction() {
     }
 
     @Override
-    public void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
+    public void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
         try {
             BindingNode node = (BindingNode) selected;
             if (Messages.NO == Messages.showYesNoDialog("Delete binding '" + node.getName() + "'.\nAre you sure?",

src/main/java/org/jboss/tools/intellij/openshift/actions/binding/ShowBindingDetailsAction.java

@@ -24,7 +24,7 @@ public ShowBindingDetailsAction() {
     }
 
     @Override
-    public void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
+    public void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
         BindingNode node = (BindingNode) selected;
         BindingDetailDialog dialog = new BindingDetailDialog(anActionEvent.getProject(), null, node.getBinding());
         dialog.show();

src/main/java/org/jboss/tools/intellij/openshift/actions/cluster/AboutAction.java

@@ -33,7 +33,7 @@ public AboutAction() {
   protected String getTelemetryActionName() { return "about"; }
 
   @Override
-  public void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
+  public void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
     runWithProgress((ProgressIndicator progress) -> {
       try {
         odo.about();

src/main/java/org/jboss/tools/intellij/openshift/actions/cluster/LoginAction.java

@@ -37,7 +37,7 @@ public LoginAction() {
     protected String getTelemetryActionName() { return "login to cluster"; }
 
   @Override
-  public void actionPerformed(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
+  public void actionPerformedOnSelectedObject(AnActionEvent anActionEvent, Object selected, @NotNull Odo odo) {
     ApplicationsRootNode clusterNode = (ApplicationsRootNode) selected;
     runWithProgress((ProgressIndicator progress) -> {
         try {