Fix node-selection aggregate interface wiring

NodeSelectionCommands and NodeSelectionAsyncCommands did not extend
the ACL and Array node-selection groups, and NodeSelectionAsyncCommands
extended the sync NodeSelectionStreamCommands instead of
NodeSelectionStreamAsyncCommands.

Breaking change: stream commands on AsyncNodeSelection now return
AsyncExecutions<T> instead of Executions<T>.

Removes the NODE_SELECTION_AGGREGATE_PENDING exemption so the
consistency test suite enforces the aggregate wiring again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: uglide

src/main/java/io/lettuce/core/cluster/api/async/NodeSelectionAsyncCommands.java

@@ -1,7 +1,6 @@
 package io.lettuce.core.cluster.api.async;
 
 import io.lettuce.core.cluster.api.NodeSelectionSupport;
-import io.lettuce.core.cluster.api.sync.NodeSelectionStreamCommands;
 
 /**
  * Asynchronous and thread-safe Redis API to execute commands on a {@link NodeSelectionSupport}.
@@ -10,12 +9,13 @@
  * @author Tihomir Mateev
  * @author Yordan Tsintsov
  */
-public interface NodeSelectionAsyncCommands<K, V> extends BaseNodeSelectionAsyncCommands<K, V>,
-        NodeSelectionFunctionAsyncCommands<K, V>, NodeSelectionGeoAsyncCommands<K, V>, NodeSelectionHashAsyncCommands<K, V>,
-        NodeSelectionHLLAsyncCommands<K, V>, NodeSelectionKeyAsyncCommands<K, V>, NodeSelectionListAsyncCommands<K, V>,
-        NodeSelectionScriptingAsyncCommands<K, V>, NodeSelectionServerAsyncCommands<K, V>, NodeSelectionSetAsyncCommands<K, V>,
-        NodeSelectionSortedSetAsyncCommands<K, V>, NodeSelectionStreamCommands<K, V>, NodeSelectionStringAsyncCommands<K, V>,
-        NodeSelectionJsonAsyncCommands<K, V>, NodeSelectionVectorSetAsyncCommands<K, V>, NodeSelectionSearchAsyncCommands<K, V>,
-        NodeSelectionBloomFilterAsyncCommands<K, V>, NodeSelectionCuckooFilterAsyncCommands<K, V>,
-        NodeSelectionTopKAsyncCommands<K, V> {
+public interface NodeSelectionAsyncCommands<K, V>
+        extends BaseNodeSelectionAsyncCommands<K, V>, NodeSelectionAclAsyncCommands<K, V>,
+        NodeSelectionArrayAsyncCommands<K, V>, NodeSelectionFunctionAsyncCommands<K, V>, NodeSelectionGeoAsyncCommands<K, V>,
+        NodeSelectionHashAsyncCommands<K, V>, NodeSelectionHLLAsyncCommands<K, V>, NodeSelectionKeyAsyncCommands<K, V>,
+        NodeSelectionListAsyncCommands<K, V>, NodeSelectionScriptingAsyncCommands<K, V>, NodeSelectionServerAsyncCommands<K, V>,
+        NodeSelectionSetAsyncCommands<K, V>, NodeSelectionSortedSetAsyncCommands<K, V>, NodeSelectionStreamAsyncCommands<K, V>,
+        NodeSelectionStringAsyncCommands<K, V>, NodeSelectionJsonAsyncCommands<K, V>, NodeSelectionVectorSetAsyncCommands<K, V>,
+        NodeSelectionSearchAsyncCommands<K, V>, NodeSelectionBloomFilterAsyncCommands<K, V>,
+        NodeSelectionCuckooFilterAsyncCommands<K, V>, NodeSelectionTopKAsyncCommands<K, V> {
 }

src/main/java/io/lettuce/core/cluster/api/sync/NodeSelectionCommands.java

@@ -8,11 +8,12 @@
  * @author Mark Paluch
  * @author Tihomir Mateev
  */
-public interface NodeSelectionCommands<K, V> extends BaseNodeSelectionCommands<K, V>, NodeSelectionFunctionCommands<K, V>,
-        NodeSelectionGeoCommands<K, V>, NodeSelectionHashCommands<K, V>, NodeSelectionHLLCommands<K, V>,
-        NodeSelectionKeyCommands<K, V>, NodeSelectionListCommands<K, V>, NodeSelectionScriptingCommands<K, V>,
-        NodeSelectionServerCommands<K, V>, NodeSelectionSetCommands<K, V>, NodeSelectionSortedSetCommands<K, V>,
-        NodeSelectionStreamCommands<K, V>, NodeSelectionStringCommands<K, V>, NodeSelectionJsonCommands<K, V>,
-        NodeSelectionVectorSetCommands<K, V>, NodeSelectionSearchCommands<K, V>, NodeSelectionBloomFilterCommands<K, V>,
-        NodeSelectionCuckooFilterCommands<K, V>, NodeSelectionTopKCommands<K, V> {
+public interface NodeSelectionCommands<K, V>
+        extends BaseNodeSelectionCommands<K, V>, NodeSelectionAclCommands<K, V>, NodeSelectionArrayCommands<K, V>,
+        NodeSelectionFunctionCommands<K, V>, NodeSelectionGeoCommands<K, V>, NodeSelectionHashCommands<K, V>,
+        NodeSelectionHLLCommands<K, V>, NodeSelectionKeyCommands<K, V>, NodeSelectionListCommands<K, V>,
+        NodeSelectionScriptingCommands<K, V>, NodeSelectionServerCommands<K, V>, NodeSelectionSetCommands<K, V>,
+        NodeSelectionSortedSetCommands<K, V>, NodeSelectionStreamCommands<K, V>, NodeSelectionStringCommands<K, V>,
+        NodeSelectionJsonCommands<K, V>, NodeSelectionVectorSetCommands<K, V>, NodeSelectionSearchCommands<K, V>,
+        NodeSelectionBloomFilterCommands<K, V>, NodeSelectionCuckooFilterCommands<K, V>, NodeSelectionTopKCommands<K, V> {
 }

src/test/java/io/lettuce/core/api/consistency/AggregateInterfaceConsistencyUnitTests.java

@@ -80,7 +80,7 @@ void nodeSelectionAggregatesCoverAllNodeSelectionGroups() {
         SoftAssertions softly = new SoftAssertions();
 
         for (CommandInterfaces group : CLUSTER_GROUPS) {
-            if (!group.hasNodeSelection() || KnownApiDeviations.NODE_SELECTION_AGGREGATE_PENDING.contains(group.name())) {
+            if (!group.hasNodeSelection()) {
                 continue;
             }
             assertExtends(softly, NodeSelectionCommands.class, group.nodeSelectionSync());

src/test/java/io/lettuce/core/api/consistency/KnownApiDeviations.java

@@ -112,15 +112,6 @@ public final class KnownApiDeviations {
      */
     public static final Set<String> NOT_ON_NODE_SELECTION_SYNC = setOf("dispatch");
 
-    /**
-     * Command groups whose node-selection aggregate wiring is known to be incomplete: {@code NodeSelectionCommands} and
-     * {@code NodeSelectionAsyncCommands} do not extend the ACL and Array groups, and {@code NodeSelectionAsyncCommands} extends
-     * the <em>sync</em> {@code NodeSelectionStreamCommands} instead of the async flavor. Correcting the Stream wiring changes
-     * the return types of stream commands on {@code AsyncNodeSelection} from {@code Executions} to {@code AsyncExecutions} — a
-     * breaking change scheduled for the 8.0 release.
-     */
-    public static final Set<String> NODE_SELECTION_AGGREGATE_PENDING = setOf("ACL", "ARRAY", "STREAM");
-
     /**
      * Sync methods with no coroutine counterpart. From {@code KotlinCompilationUnitFactory#SKIP_METHODS}.
      */