Skip to content

Commit 0c27ce5

Browse files
committed
test: improve version-specific test coverage
- Add `testWithClientIfVersionWithinRange` method to run tests for specific Redis versions - Refactor TestUtils to handle version comparisons more accurately - Update test utilities across Redis modules to run tests against multiple versions, and not against latest only
1 parent d647d34 commit 0c27ce5

17 files changed

+565
-191
lines changed

packages/bloom/lib/test-utils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import TestUtils from '@redis/test-utils';
22
import RedisBloomModules from '.';
33

4-
export default new TestUtils({
4+
export default TestUtils.createFromConfig({
55
dockerImageName: 'redislabs/client-libs-test',
6-
dockerImageVersionArgument: 'redisbloom-version',
6+
dockerImageVersionArgument: 'redis-version',
77
defaultDockerVersion: '8.0-M04-pre'
88
});
99

packages/client/lib/test-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { CredentialsProvider } from './authx';
55
import { Command } from './RESP/types';
66
import { BasicCommandParser } from './client/parser';
77

8-
const utils = new TestUtils({
8+
const utils = TestUtils.createFromConfig({
99
dockerImageName: 'redislabs/client-libs-test',
1010
dockerImageVersionArgument: 'redis-version',
1111
defaultDockerVersion: '8.0-M04-pre'

packages/entraid/lib/test-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { IdentityProvider, StreamingCredentialsProvider, TokenManager, TokenResp
33
import TestUtils from '@redis/test-utils';
44
import { EntraidCredentialsProvider } from './entraid-credentials-provider';
55

6-
export const testUtils = new TestUtils({
6+
export const testUtils = TestUtils.createFromConfig({
77
dockerImageName: 'redislabs/client-libs-test',
88
dockerImageVersionArgument: 'redis-version',
99
defaultDockerVersion: '8.0-M04-pre'

packages/graph/lib/test-utils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import TestUtils from '@redis/test-utils';
22
import RedisGraph from '.';
33

44

5-
export default new TestUtils({
5+
export default TestUtils.createFromConfig({
66
dockerImageName: 'redislabs/client-libs-test',
7-
dockerImageVersionArgument: 'redisgraph-version',
7+
dockerImageVersionArgument: 'redis-version',
88
defaultDockerVersion: '8.0-M04-pre'
99
});
1010

packages/json/lib/test-utils.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import TestUtils from '@redis/test-utils';
22
import RedisJSON from '.';
33

4-
export default new TestUtils({
4+
export default TestUtils.createFromConfig({
55
dockerImageName: 'redislabs/client-libs-test',
6-
dockerImageVersionArgument: 'redisgraph-version',
6+
dockerImageVersionArgument: 'redis-version',
77
defaultDockerVersion: '8.0-M04-pre'
88
});
99

packages/search/lib/commands/CONFIG_SET.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('FT.CONFIG SET', () => {
1818
);
1919
}, GLOBAL.SERVERS.OPEN);
2020

21-
testUtils.testWithClient('setSearchConfigGloballyTest', async client => {
21+
testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'setSearchConfigGloballyTest', async client => {
2222

2323
const normalizeObject = obj => JSON.parse(JSON.stringify(obj));
2424
assert.equal(await client.configSet('search-default-dialect', '3'),

0 commit comments

Comments
 (0)