close #2216 - add support for TDIGEST.MERGESTORE and make compression optional on TDIGEST.CREATE

Author: leibale

packages/bloom/lib/commands/t-digest/CREATE.spec.ts

@@ -3,11 +3,20 @@ import testUtils, { GLOBAL } from '../../test-utils';
 import { transformArguments } from './CREATE';
 
 describe('TDIGEST.CREATE', () => {
-    it('transformArguments', () => {
-        assert.deepEqual(
-            transformArguments('key', 100),
-            ['TDIGEST.CREATE', 'key', '100']
-        );
+    describe('transformArguments', () => {
+        it('without options', () => {
+            assert.deepEqual(
+                transformArguments('key'),
+                ['TDIGEST.CREATE', 'key']
+            );
+        });
+
+        it('without compression', () => {
+            assert.deepEqual(
+                transformArguments('key', 100),
+                ['TDIGEST.CREATE', 'key', '100']
+            );
+        });
     });
 
     testUtils.testWithClient('client.tDigest.create', async client => {

packages/bloom/lib/commands/t-digest/CREATE.ts

@@ -4,13 +4,23 @@ export const FIRST_KEY_INDEX = 1;
 
 export function transformArguments(
     key: RedisCommandArgument,
-    compression: number
+    it('simple', () => {
+        assert.deepEqual(
+            transformArguments('key', 100),
+            ['TDIGEST.CREATE', 'key', '100']
+        );
+    });?: number
 ): RedisCommandArguments {
-    return [
+    const args = [
         'TDIGEST.CREATE',
-        key,
-        compression.toString()
+        key
     ];
+
+    if (compression) {
+        args.push(compression.toString());
+    }
+
+    return args;
 }
 
 export declare function transformReply(): 'OK';

packages/bloom/lib/commands/t-digest/MERGE.ts

@@ -3,13 +3,13 @@ import { RedisCommandArgument, RedisCommandArguments } from '@redis/client/dist/
 export const FIRST_KEY_INDEX = 1;
 
 export function transformArguments(
-    toKey: RedisCommandArgument,
-    fromKey: RedisCommandArgument
+    destKey: RedisCommandArgument,
+    srcKey: RedisCommandArgument
 ): RedisCommandArguments {
     return [
         'TS.MERGE',
-        toKey,
-        fromKey
+        destKey,
+        srcKey
     ];
 }
 

packages/bloom/lib/commands/t-digest/MERGESTORE.spec.ts

@@ -0,0 +1,39 @@
+import { strict as assert } from 'assert';
+import testUtils, { GLOBAL } from '../../test-utils';
+import { transformArguments } from './MERGESTORE';
+
+describe('TDIGEST.MERGESTORE', () => {
+    describe('transformArguments', () => {
+        describe('srcKeys', () => {
+            it('string', () => {
+                assert.deepEqual(
+                    transformArguments('dest', ['1', '2']),
+                    ['TDIGEST.MERGESTORE', 'dest', '1', '1', '2']
+                );
+            });
+
+            it('Array', () => {
+                assert.deepEqual(
+                    transformArguments('dest', 'src'),
+                    ['TDIGEST.MERGESTORE', 'dest', '1', 'src']
+                );
+            });
+        });
+
+        it('with COMPRESSION', () => {
+            assert.deepEqual(
+                transformArguments('dest', 'src', {
+                    COMPRESSION: 100
+                }),
+                ['TDIGEST.MERGESTORE', 'dest', '1', 'src', 'COMPRESSION', '100']
+            );
+        });
+    });
+
+    testUtils.testWithClient('client.tDigest.mergeStore', async client => {
+        assert.equal(
+            await client.tDigest.mergeStore('dest', 'src'),
+            'OK'
+        );
+    }, GLOBAL.SERVERS.OPEN);
+});

packages/bloom/lib/commands/t-digest/MERGESTORE.ts

@@ -0,0 +1,29 @@
+import { RedisCommandArgument, RedisCommandArguments } from '@redis/client/dist/lib/commands';
+import { pushVerdictArgument } from '@redis/client/dist/lib/commands/generic-transformers';
+
+export const FIRST_KEY_INDEX = 1;
+
+interface MergeStoreOptions {
+    COMPRESSION?: number;
+}
+
+export function transformArguments(
+    destKey: RedisCommandArgument,
+    srcKeys: RedisCommandArgument | Array<RedisCommandArgument>,
+    options?: MergeStoreOptions
+): RedisCommandArguments {
+    let args = [
+        'TS.MERGESTORE',
+        destKey,
+    ];
+
+    args = pushVerdictArgument(args, srcKeys);
+
+    if (options?.COMPRESSION) {
+        args.push('COMPRESSION', options.COMPRESSION.toString());
+    }
+
+    return args;
+}
+
+export declare function transformReply(): 'OK';

packages/bloom/lib/commands/t-digest/index.ts

@@ -4,6 +4,7 @@ import * as CREATE from './CREATE';
 import * as INFO from './INFO';
 import * as MAX from './MAX';
 import * as MERGE from './MERGE';
+import * as MERGESTORE from './MERGESTORE';
 import * as MIN from './MIN';
 import * as QUANTILE from './QUANTILE';
 import * as RESET from './RESET';
@@ -22,6 +23,8 @@ export default {
     max: MAX,
     MERGE,
     merge: MERGE,
+    MERGESTORE,
+    mergeStore: MERGESTORE,
     MIN,
     min: MIN,
     QUANTILE,