Make maint-notification scenario tests generic; drop ASM-specific client code

The fault injector now owns the ASM/reshard logic behind the SLOT_MIGRATE_ASM toggle,
so the client no longer needs ASM-specific handling:

- Remove the AsmTriggers enum and the include_asm threading (fault_injector_client.py,
  maint_notifications_helpers.py); GET /slot-migrate returns whatever the FI toggle decides.
- Delete TestClusterClientPushNotificationsWithAsmEffectTrigger, _asm_params, the ASM_*
  timeouts, and the node-cache "drain until settled" loop.
- Add a generic add (+1) cluster test mirroring the remove (-1) test.

Pointed at an FI with SLOT_MIGRATE_ASM=on, the generic cluster tests exercise the
reshard/ASM path with zero client changes (verified live: slot-shuffle + add).

Author: kiryazovi-redis

tests/test_scenario/fault_injector_client.py

@@ -49,19 +49,6 @@ class SlotMigrateEffects(str, Enum):
     SLOT_SHUFFLE = "slot-shuffle"
 
 
-class AsmTriggers(str, Enum):
-    """ASM (Atomic Slot Migration) trigger names on the slot-migrate scenario.
-
-    These are only returned by GET /slot-migrate when include_asm=true and require an
-    ASM-enabled cluster (asm_client_maint_notifications) + dbconfig.
-    """
-
-    MIGRATE_SLOTS = "asm_migrate_slots"  # effect slot-shuffle
-    SCALE_OUT = "asm_scale_out"  # effect add
-    SCALE_IN = "asm_scale_in"  # effect remove
-    REBALANCE = "asm_rebalance"  # effect slot-shuffle
-
-
 class TopologyChangeStandaloneEffects(str, Enum):
     DATA_MOVEMENT_CONN_DROP = "data_movement_conn_drop"
     DATA_MOVEMENT_NO_CONN_DROP = "data_movement_no_conn_drop"
@@ -134,7 +121,6 @@ def get_moving_ttl(self) -> int:
     def get_slot_migrate_triggers(
         self,
         effect_name: SlotMigrateEffects,
-        include_asm: bool = False,
     ) -> Dict[str, Any]:
         pass
 
@@ -378,17 +364,13 @@ def find_database_id_by_name(
     def get_slot_migrate_triggers(
         self,
         effect_name: SlotMigrateEffects,
-        include_asm: bool = False,
     ) -> Dict[str, Any]:
         """Get available triggers(trigger name + db example config) for a slot migration effect.
 
-        When include_asm is True, the fault injector also returns the ASM triggers
-        (asm_migrate_slots / asm_scale_out / asm_scale_in / asm_rebalance) with an
-        ASM-enabled dbconfig.
+        The fault injector's SLOT_MIGRATE_ASM toggle decides the trigger subset returned (ASM
+        `reshard` when on; migrate/failover when off), so the client stays generic.
         """
         path = f"/slot-migrate?effect={effect_name.value}&cluster_index=0"
-        if include_asm:
-            path += "&include_asm=true"
         return self._make_request("GET", path)
 
     def get_topology_change_standalone_triggers(
@@ -544,7 +526,6 @@ def get_moving_ttl(self) -> int:
     def get_slot_migrate_triggers(
         self,
         effect_name: SlotMigrateEffects,
-        include_asm: bool = False,
     ) -> Dict[str, Any]:
         raise NotImplementedError("Not implemented for proxy server")
 

tests/test_scenario/maint_notifications_helpers.py

@@ -124,10 +124,9 @@ def find_database_id_by_name(
     def get_slot_migrate_triggers(
         fault_injector: FaultInjectorClient,
         effect_name: SlotMigrateEffects,
-        include_asm: bool = False,
     ) -> Dict[str, Any]:
         """Get available triggers(trigger name + db example config) for a slot migration effect."""
-        return fault_injector.get_slot_migrate_triggers(effect_name, include_asm=include_asm)
+        return fault_injector.get_slot_migrate_triggers(effect_name)
 
     @staticmethod
     def get_topology_change_standalone_triggers(
@@ -302,24 +301,23 @@ def generate_params(
     effect_names: list[SlotMigrateEffects | TopologyChangeStandaloneEffects],
     skip_combinations: list[tuple[SlotMigrateEffects, str]] = [],
     endpoint_types: Optional[list[EndpointType]] = None,
-    include_asm: bool = False,
 ):
     """Build parametrize tuples for maint-notification scenario tests.
 
     Returns a list of (effect_name, trigger, dbconfig, db_name) tuples, or
     (effect_name, trigger, dbconfig, db_name, endpoint_type) when endpoint_types
     is provided.
 
-    When include_asm is True, ASM triggers (asm_migrate_slots / asm_scale_out /
-    asm_scale_in / asm_rebalance) are included for SlotMigrateEffects.
+    The trigger subset is whatever the fault injector returns (its SLOT_MIGRATE_ASM toggle
+    decides ASM `reshard` vs migrate/failover), so these tests stay generic.
     """
     params = []
     try:
         logging.info(f"Extracting params for test with effect_names: {effect_names}")
         for effect_name in effect_names:
             if isinstance(effect_name, SlotMigrateEffects):
                 triggers_data = ClusterOperations.get_slot_migrate_triggers(
-                    fault_injector_client, effect_name, include_asm=include_asm
+                    fault_injector_client, effect_name
                 )
             else:
                 triggers_data = (