Skip to content

Commit e19a91b

Browse files
committed
self reference in SentinelConnectionPool changed to weak reference
circular reference changed to weak reference to enable garbage collection
1 parent 71c64c2 commit e19a91b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

redis/sentinel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import random
3+
import weakref
34

45
from redis.client import StrictRedis
56
from redis.connection import ConnectionPool, Connection
@@ -56,7 +57,7 @@ def __init__(self, service_name, sentinel_manager, **kwargs):
5657
self.is_master = kwargs.pop('is_master', True)
5758
self.check_connection = kwargs.pop('check_connection', False)
5859
super(SentinelConnectionPool, self).__init__(**kwargs)
59-
self.connection_kwargs['connection_pool'] = self
60+
self.connection_kwargs['connection_pool'] = weakref.proxy(self)
6061
self.service_name = service_name
6162
self.sentinel_manager = sentinel_manager
6263
self.master_address = None

0 commit comments

Comments
 (0)