Skip to content

Commit c6ffabf

Browse files
committed
Skip node10 resolution in the attw check so subpath entries can be included
1 parent 63fb0eb commit c6ffabf

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

.github/workflows/test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,12 @@ jobs:
213213
run: pnpm install
214214

215215
# Note: We currently expect "FalseCJS" failures for Node16 + `moduleResolution: "node16",
216+
# `--profile node16` drops the node10 resolution check. The subpath
217+
# entry points (`alternate-renderers`, `signals`) only resolve through
218+
# the `exports` map, which node10 does not read, and we do not support
219+
# Node 10 style resolution for them.
216220
- name: Run are-the-types-wrong
217-
run: pnpm exec attw ./package.tgz --format table --ignore-rules false-cjs --exclude-entrypoints alternate-renderers
221+
run: pnpm exec attw ./package.tgz --format table --ignore-rules false-cjs --profile node16
218222

219223
test-published-artifact:
220224
name: Test Published Artifact ${{ matrix.example }}

0 commit comments

Comments
 (0)