Skip to content

Fix remaining docs references to slice field #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markerikson opened this issue Oct 16, 2019 · 3 comments · Fixed by #220
Closed

Fix remaining docs references to slice field #219

markerikson opened this issue Oct 16, 2019 · 3 comments · Fixed by #220
Labels
docs good first issue Good for newcomers

Comments

@markerikson
Copy link
Collaborator

markerikson commented Oct 16, 2019 •
edited
Loading

We missed some uses of slice in the docs when we made the changes in #197 . In particular, I see several references in the "Usage Guide" page.

I'd like someone to replace any remaining references with name, per the API docs.
@markerikson markerikson added docs good first issue Good for newcomers labels Oct 16, 2019
@smorimoto
Copy link
Contributor

Can I take this?

@markerikson
Copy link
Collaborator Author

@imbsky : sure, go ahead!

@smorimoto smorimoto mentioned this issue Oct 16, 2019
Merged
@smorimoto
Copy link
Contributor

Opened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename slice to name and tweaks some examples
2 participants
@markerikson @smorimoto