Skip to content

Outdated documentation of immutable invariant options on the homepage #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ntamas opened this issue Apr 10, 2020 · 3 comments · Fixed by #492
Closed

Outdated documentation of immutable invariant options on the homepage #491

ntamas opened this issue Apr 10, 2020 · 3 comments · Fixed by #492

Comments

@ntamas
Copy link

ntamas commented Apr 10, 2020

The API reference on the homepage currently states that the paths to ignore in the immutable state middleware can be configured with the ignore key. This is not true; when the middleware was merged in the most recent version, the key was renamed to ignoredPaths, relying on the old ignore key has no effect. (The new middleware also has a warnAfter key for what it's worth). The API reference on the homepage should be updated to avoid confusion. Also, it would probably be a good idea to treat ignore as an alias for ignoredPaths in order not to break backwards compatibility in a minor release.

Thanks a lot in advance!

@markerikson
Copy link
Collaborator

Could you file a PR to update the docs accordingly?

And yeah, looks like the PR from @msutkowski (#381) had the new key name and I didn't catch that that was different than the original lib. It'd be great if you could file a PR to fix that as well.

@msutkowski
Copy link
Member

@ntamas Very sorry about that! I was intending to keep the API surface of the middleware consistent and forgot to alias it 🤦‍♂️

@ntamas
Copy link
Author

ntamas commented Apr 10, 2020

Thanks guys, you were faster than me - I was planning to send a PR tonight after the kids went to bed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants