refactor(types/actions): allow type-setting args on ActionCreator (#3797)

Author: zanona

docs/Glossary.md

@@ -66,7 +66,7 @@ The base dispatch function _always_ synchronously sends an action to the store's
 ## Action Creator
 
 ```js
-type ActionCreator = (...args: any) => Action | AsyncAction
+type ActionCreator<A, P extends any[] = any[]> = (...args: P) => Action | AsyncAction
 ```
 
 An _action creator_ is, quite simply, a function that creates an action. Do not confuse the two terms—again, an action is a payload of information, and an action creator is a factory that creates an action.

src/types/actions.ts

@@ -49,13 +49,13 @@ export interface AnyAction extends Action {
  *
  * @template A Returned action type.
  */
-export interface ActionCreator<A> {
-  (...args: any[]): A
+export interface ActionCreator<A, P extends any[] = any[]> {
+  (...args: P): A
 }
 
 /**
  * Object whose values are action creator functions.
  */
-export interface ActionCreatorsMapObject<A = any> {
-  [key: string]: ActionCreator<A>
+export interface ActionCreatorsMapObject<A = any, P extends any[] = any[]> {
+  [key: string]: ActionCreator<A, P>
 }

test/typescript/actionCreators.ts

@@ -10,7 +10,7 @@ interface AddTodoAction extends Action {
   text: string
 }
 
-const addTodo: ActionCreator<AddTodoAction> = (text: string) => ({
+const addTodo: ActionCreator<AddTodoAction, [string]> = text => ({
   type: 'ADD_TODO',
   text
 })
@@ -19,7 +19,7 @@ const addTodoAction: AddTodoAction = addTodo('test')
 
 type AddTodoThunk = (dispatch: Dispatch) => AddTodoAction
 
-const addTodoViaThunk: ActionCreator<AddTodoThunk> = (text: string) => (
+const addTodoViaThunk: ActionCreator<AddTodoThunk> = text => (
   dispatch: Dispatch
 ) => ({
   type: 'ADD_TODO',
@@ -33,8 +33,8 @@ const boundAddTodo = bindActionCreators(addTodo, dispatch)
 const dispatchedAddTodoAction: AddTodoAction = boundAddTodo('test')
 
 const boundAddTodoViaThunk = bindActionCreators<
-  ActionCreator<AddTodoThunk>,
-  ActionCreator<AddTodoAction>
+  ActionCreator<AddTodoThunk, [string]>,
+  ActionCreator<AddTodoAction, [string]>
 >(addTodoViaThunk, dispatch)
 
 const dispatchedAddTodoViaThunkAction: AddTodoAction = boundAddTodoViaThunk(
@@ -48,11 +48,11 @@ const otherDispatchedAddTodoAction: AddTodoAction = boundActionCreators.addTodo(
 )
 
 interface M extends ActionCreatorsMapObject {
-  addTodoViaThunk: ActionCreator<AddTodoThunk>
+  addTodoViaThunk: ActionCreator<AddTodoThunk, [string]>
 }
 
 interface N extends ActionCreatorsMapObject {
-  addTodoViaThunk: ActionCreator<AddTodoAction>
+  addTodoViaThunk: ActionCreator<AddTodoAction, [string]>
 }
 
 const boundActionCreators2 = bindActionCreators<M, N>(