Skip to content

Remove or polyfill the use of Symbol in the examples #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daannijkamp opened this issue Jan 26, 2017 · 1 comment
Closed

Remove or polyfill the use of Symbol in the examples #2217

daannijkamp opened this issue Jan 26, 2017 · 1 comment

Comments

@daannijkamp
Copy link

The real word example makes use of JavaScript Symbols. This doesn't work in older browsers¸ also Create React App doesn't provide any polyfill for Symbols.
I believe that this should be removed from the example. Because It is only used once, and a polyfill needs some optimizations require it.
What do you think?
@gaearon
Copy link
Contributor

gaearon commented Jan 26, 2017

Sure, I don't think it's important there. Send a PR?

@yefremov yefremov mentioned this issue Feb 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @daannijkamp