Use more ES6 syntaxes in the real world example #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Sep 18, 2016
| key={repo.fullName} /> | ||
| ) | ||
| } | ||
| renderRepo = ([ repo, owner ]) => <Repo |
There was a problem hiding this comment.
This shouldn’t be autobound (not an event handler).
This is also hard to read for somebody new to this syntax.
Please format it the way it was before.
| } | ||
| case failureType: | ||
| return merge({}, state, { | ||
| return { ...state, |
There was a problem hiding this comment.
Please put ...state on the next line.
return {
...state,
stuff
}
|
I tweaked this do don't worry! |
|
@gaearon I don't. I'm really happy to get some advice so I can make my next PRs better suited to the conventions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the async example files to using fat arrows, spread operators and stateless components.
This is a follow up to what I started in #1942 and #1945
References #1800