Skip to content

tests for the examples #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2015
Merged

tests for the examples #380

merged 2 commits into from
Aug 4, 2015

Conversation

sambs
Copy link
Contributor

@sambs sambs commented Jul 31, 2015

Supersedes #278

@sambs sambs mentioned this pull request Jul 31, 2015
Closed
@gaearon
Copy link
Contributor

gaearon commented Jul 31, 2015

Thank you! I'll look at it a bit later. Terrific work :-)

@quicksnap
Copy link
Contributor

Before merging this, could you consider adding { cmd: 'npm', args: ['test'] } to examples/buildAll.js? (You may need to rebase to latest to see that file.) This will cause the example tests to run on Travis.

gaearon added a commit that referenced this pull request Aug 4, 2015
@gaearon
Merge pull request #380 from sambs/example-tests-rebased
2a08009 
tests for the examples
@gaearon gaearon merged commit 2a08009 into reduxjs:breaking-changes-1.0 Aug 4, 2015
@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2015

Thank you again. Wow.

@sambs
Copy link
Contributor Author

sambs commented Aug 4, 2015

Great! I'm glad I could help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambs @gaearon @quicksnap